It is much better with the fix. We don't count margins, so the aspect ratio is still not valid for narrow images.
Line in fileItem.js let width = Prefs.getDesiredWidth(scaleFactor, 0) was also erroneous, because margins are not 0 (at least, with default theme). Here is how the margins are being calculated: this._extra_width = themeNode.get_margin(St.Side.LEFT) + themeNode.get_margin(St.Side.RIGHT) + themeNode.get_border_width(St.Side.LEFT) + themeNode.get_border_width(St.Side.RIGHT) + themeNode.get_horizontal_padding(); this._extra_height = themeNode.get_margin(St.Side.TOP) + themeNode.get_margin(St.Side.BOTTOM) + themeNode.get_border_width(St.Side.TOP) + themeNode.get_border_width(St.Side.BOTTOM) + themeNode.get_vertical_padding(); (they are used in Prefs.getDesiredWidth and Prefs.getDesiredHeight functions) Aspect ratio is still not correct for narrow images. To reproduce, create an image that has aspect ratio ~0.5 (e.g. width = 250 and height = 500). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1868529 Title: Stretched image previews on desktop To manage notifications about this bug go to: https://bugs.launchpad.net/gnome-shell-extension-desktop-icons/+bug/1868529/+subscriptions -- ubuntu-bugs mailing list email@example.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs