[The following is probably outside the scope of this SRU, but since this
will be the first time that people see this logging, maybe you do want
to improve it now.]

The existing log statements are:

logger -p daemon.info mdcheck start checking $dev
logger -p daemon.info mdcheck continue checking $dev from $start
logger -p daemon.info mdcheck finished checking $dev
logger -p daemon.info pause checking $dev at `cat $fl`

Some issues:
1. The last one does not contain "mdcheck", which is inconsistent and hampers 
grepping.
2. These do not set a "tag", so we get "root" as the tag. The typical syslog 
convention is that the tag is the daemon/script name. I propose "-t mdcheck". 
That can just be the "mdcheck" that starts the log messages now; there is no 
need for two "mdcheck"s.
3. nit: I'd use $() instead of ``.

That is, I would change them to the following:

logger -p daemon.info -t mdcheck start checking $dev
logger -p daemon.info -t mdcheck continue checking $dev from $start
logger -p daemon.info -t mdcheck finished checking $dev
logger -p daemon.info -t mdcheck pause checking $dev at $(cat $fl)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1852747

Title:
  mdcheck_start.service trying to start unexisting file

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/mdadm/+bug/1852747/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to