Comment on attachment 442519 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442519&action=review
This is great! Looks like the test is still failing on Mac and this should handle a failed call to hb_language_from_string, but this is a good start. > Source/WebCore/platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:548 > + hb_language_t language = hb_language_from_string(reinterpret_cast<const > char*>(m_font.fontDescription().computedLocale().characters8()), -1); I think it would be better to do this here: hb_language_from_string(m_font.fontDescription().computedLocale().string().toUTF8().data()), -1); This would allow you to avoid the reinterpret_cast. It seems like this call should check for and handle (not set the language below) the situation where HB_LANGUAGE_INVALID is returned here. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/560795 Title: WebKit freetype2 font backend doesn't support "locl" tables To manage notifications about this bug go to: https://bugs.launchpad.net/webkit/+bug/560795/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
