Review for Package: gnome-text-editor
[Summary]
MIR team ack under the condition gtksourceview5 is already transition is
promoted to main. I think the easiest is to transition to it so that it’s
promoted and then promoting this one. This is the reason I switch it to
incomplete until the transition is done to avoid promotions by error beforehand.
Recommended TODOs:
- Maybe fix the only warning present due to unused variable and propose it
upstream:
../src/editor-application.c: In function ‘editor_application_command_line’:
../src/editor-application.c:412:22: warning: unused variable ‘self’
[-Wunused-variable]
412 | EditorApplication *self = (EditorApplication *)app;
| ^~~~
[Duplication]
gedit provides the same functionality, but it will be replaced by this new
application.
[Dependencies]
OK:
- no -dev/-debug/-doc packages that need exclusion
- No dependencies in main that are only superficially tested requiring
more tests now.
Problems:
- gtksourceview5 is needed. See top suggestion for transition being done before
promoting this package.
[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking
- does not have odd Built-Using entries
OK:
- not a go package, no extra constraints to consider in that regard
[Security]
OK:
- history of CVEs does not look concerning
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not parse data formats
- does not open a port/socket
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)
[Common blockers]
OK:
- does not FTBFS currently
- does have a test suite that runs at build time
- test suite fails will fail the build upon error.
- does not have a test suite that runs as autopkgtest but a manual test plan is
provided
- no new python2 dependency
[Packaging red flags]
OK:
- Ubuntu does not carry a delta
- symbols tracking not applicable for this kind of code.
- d/watch is present and looks ok
- Upstream update history is good
- Debian/Ubuntu update history is good
- the current release is packaged
- promoting this does not seem to cause issues for MOTUs that so far
- no massive Lintian warnings
- d/rules is rather clean
- It is not on the lto-disabled list
[Upstream red flags]
OK:
- no incautious use of malloc/sprintf (as far as we can check it)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside
tests)
- no use of user nobody
- no use of setuid
- use of setuid, but ok because TBD (prefer systemd to set those
for services)
- no important open bugs (crashers, etc) in Debian or Ubuntu
- no dependency on webkit, qtwebkit, seed or libgoa-*
- part of the UI, desktop file is ok
- translation present
Problems:
- One warning during build, see top explanation on recommended TODOs as this
one is small.
** Changed in: gnome-text-editor (Ubuntu)
Status: New => Incomplete
** Changed in: gnome-text-editor (Ubuntu)
Assignee: Didier Roche (didrocks) => (unassigned)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1971973
Title:
[MIR] gnome-text-editor
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-text-editor/+bug/1971973/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
