A few comments after a first look at the patch:

1. You should include bug numbers in the changelog, and in the relevant patch 
files (using the Bug-Ubuntu dep3 field).
2. The version string is incorrect. The previous upload is 1:1.8.2-1, so this 
should be 1:1.8.2-1ubuntu1. It's also generally good to set the release field 
instead of leaving UNRELEASED, even though a sponsor could easily change this.
3. On this Makefile diff:

+--- a/Makefile
++++ b/Makefile
+@@ -257,6 +257,10 @@
+       $(Q)$(call descend,$(UTEST_DIR),test)
++test-installed: LIBTRACEEVENT_STATIC := $(shell dpkg -L libtraceevent-dev | 
grep libtraceevent.so)

Shouldn't this be libtraceevent.a? Further, wouldn't it be better to
make this `LIBTRACEEVENT_STATIC = -l:libtraceevent.a`?

++test-installed: force
++      $(Q)$(call descend,$(UTEST_DIR),test)
+ VIM_TAGS = $(obj)/tags
+ EMACS_TAGS = $(obj)/TAGS

I think it would also be simpler to make this patch do:

diff --git a/Makefile b/Makefile
index 41ad866..8ffc529 100644
--- a/Makefile
+++ b/Makefile
@@ -114,7 +114,7 @@ EXTRAVERSION        = $(EP_EXTRAVERSION)
 OBJ            = $@
 N              =
-LIBTRACEEVENT_STATIC = $(bdir)/libtraceevent.a
+LIBTRACEEVENT_STATIC ?= $(bdir)/libtraceevent.a
 EP_HEADERS_DIR = $(src)/include/traceevent

and then in debian/tests/utest, you can just call
LIBTRACEEVENT_STATIC='-l:libtraceevent.a'. This Makefile patch has the
advantage of probably being very upstream-able too.

You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

  [MIR] promote libtraceevent as a trace-cmd dependency

To manage notifications about this bug go to:

ubuntu-bugs mailing list

Reply via email to