Thanks for the review enr0n!

I like your solution of setting LIBTRACEEVENT_STATIC in
debian/tests/utest to have minimal changes in the Makefile.


> Shouldn't this be libtraceevent.a? Further, wouldn't it be better to make 
> this `LIBTRACEEVENT_STATIC = -l:libtraceevent.a`?

In its review didrocks specifically asked to run the tests with the
installed library. That is why I am looking for its path and using it to
replace LIBTRACEEVENT_STATIC when building the test binary. Does it make
sense? I am missing something?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2051916

Title:
  [MIR] promote libtraceevent as a trace-cmd dependency

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libtraceevent/+bug/2051916/+subscriptions


-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to