Review for Source Package: python-botocore
[Summary]
Being developed in sync with python-boto3 this is almost a copy and paste of
the other review except small changes in a few places.
MIR team ACK under the constraint to resolve the below listed
required TODOs and as much as possible having a look at the
recommended TODOs.
List of specific binary packages to be promoted to main:
python3-botocore
Specific binary packages built, but NOT to be promoted to main: <none>
This does need a security review, so I'll assign ubuntu-security
Some special conditions apply, please read bug 2061217 which has all those
details.
Required TODOs:
- #1 please add testing as discussed. I've spoken with Alberto and he is
already on extending the package to have proper tests.
[Rationale, Duplication and Ownership]
There is another package in main providing the same functionality: python-boto.
That was split in python-boto3 (bug 2061217) and python-botocore (this).
But that alternative is outdated and discontinued and this request is about
replacing the unmaintainable (and incompatible with the python in noble) old
version with the new one.
=> OK
A team is committed to own long term maintenance of this package.
=> Server, team-subscription already added
The rationale given in the report seems valid and useful for Ubuntu,
for simplestreams via the dependency as reported and for other users of
the library.
[Dependencies]
OK:
- no -dev/-debug/-doc packages that need exclusion
- No dependencies in main that are only superficially tested requiring
more tests now.
Problems:
- other Dependencies to MIR due to this, cases are already open and linked here
[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking
- does not have unexpected Built-Using entries
- not a go package, no extra constraints to consider in that regard
- not a rust package, no extra constraints to consider in that regard
Problems: None
[Security]
OK:
- history of CVEs does not look concerning
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not expose any external endpoint (port/socket/... or similar)
- does not process arbitrary web content
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)
- does not deal with cryptography (en-/decryption, certificates,
signing, ...)
- this makes appropriate (for its exposure) use of established risk
mitigation features (being a lib only it can not yet know the use-case
and thereby not define profiles)
Problems:
- does parse data formats in its interaction with the cloud. Since
many other things nowadays also provide AWS compatible backends one
can not safely assume the source can always be trusted.
- does use centralized online accounts to access the privileged AWS resources
[Common blockers]
OK:
- does not FTBFS currently
- This does not need special HW for build or test
- Python package, but using dh_python
Problems:
- does not have a test suite that runs at build time
- test suite fails will fail the build upon error.
- does not have a non-trivial test suite that runs as autopkgtest
[Packaging red flags]
OK:
- Ubuntu does not carry a delta
- symbols tracking not applicable for this kind of code.
- debian/watch is present and looks ok
- Upstream update history is good
- Debian/Ubuntu update history is ok
- promoting this does not seem to cause issues for MOTUs that so far
maintained the package
- no massive Lintian warnings
The few pedantics you reported are nice to resolve, but not critical
- debian/rules is rather clean
- It is not on the lto-disabled list
Problems:
- the current release is not packaged, but that is only the case as upstream
has almost daily releases through CI. We are on the right minor version (.34)
and subversions are here not that much of a problem.
[Upstream red flags]
OK:
- no Errors/warnings during the build
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH
- no use of user nobody (only nfsnobody for actual nfs use)
- no use of setuid / setgid
- no important open bugs (crashers, etc) in Debian or Ubuntu
- no dependency on webkit, qtwebkit, seed or libgoa-*
- not part of the UI for extra checks
- no translation present, but none needed for this case (lib only)
Problems: None
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2061751
Title:
[MIR] python-botocore as indirect dependency of simplestreams
(simplestreams -> python-boto3 -> python-s3transfer -> python-
botocore)
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/python-botocore/+bug/2061751/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
