Review for Source Package: python-s3transfer
[Summary]
MIR team ACK under the constraint to resolve the below listed
required TODOs and as much as possible having a look at the
recommended TODOs.
List of specific binary packages to be promoted to main:
python3-s3transfer
Specific binary packages built, but NOT to be promoted to main: <none>
This does need a security review, so I'll assign ubuntu-security
Some special conditions apply, please read bug 2061217 which has all those
details.
Required TODOs:
- #1 please add testing as discussed.
Recommended TODOs:
- #2 please update to the minor fix in 0.10.1
- #3 please update the package description to include the warning of this
being good for use through boto3 but not for direct use. You can grab
that from the projects webpage.
I've spoken with Alberto and he is already on extending the package to have
proper tests as well as considering the two recommended changes.
[Rationale, Duplication and Ownership]
Out of the stack around boto3 this is the only slight difference. boto already
had the boto interface for s3 and boto3 evolved on that. In fact the package
even suggests to only ever rely on the s3 interface in boto.
So there is another package in main providing the same high functionality:
python-boto. And that is what will be replaced via python-boto3 (bug 2061217),
But to be able to provide that it needs the low level functions in
python-s3transfer.
=> OK
A team is committed to own long term maintenance of this package.
=> Server, team-subscription already added
The rationale given in the report seems valid and useful for Ubuntu,
for simplestreams via the dependency as reported and for other of python-boto3.
Usually I suggest direct users of the lib as well, but in this case that should
be avoided (more on that below).
[Dependencies]
OK:
- no -dev/-debug/-doc packages that need exclusion
- No dependencies in main that are only superficially tested requiring
more tests now.
Problems:
- No other Dependencies to MIR due to this
[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking
- does not have unexpected Built-Using entries
- not a go package, no extra constraints to consider in that regard
- not a rust package, no extra constraints to consider in that regard
Problems: None
[Security]
OK:
- history of CVEs does not look concerning
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not expose any external endpoint (port/socket/... or similar)
- does not process arbitrary web content
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)
- does not deal with cryptography (en-/decryption, certificates,
signing, ...)
- this makes appropriate (for its exposure) use of established risk
mitigation features (being a lib only it can not yet know the use-case
and thereby not define profiles)
Problems:
- does parse data formats in its interaction with the cloud. Since
many other things nowadays also provide AWS compatible backends one
can not safely assume the source can always be trusted.
- does use centralized online accounts to access the privileged AWS resources
[Common blockers]
OK:
- does not FTBFS currently
- This does not need special HW for build or test
- Python package, but using dh_python
I was confused for a moment not seing it in d/rules but it uses the more
modern compat >=13 variant of dh-sequence-python3 in d/control. Double
checked the build log, and it is in use there.
Problems:
- does not have a test suite that runs at build time
- test suite fails will fail the build upon error.
- does not have a non-trivial test suite that runs as autopkgtest
[Packaging red flags]
OK:
- Ubuntu does not carry a delta
- symbols tracking not applicable for this kind of code.
- debian/watch is present and looks ok
- Upstream update history is good
- Debian/Ubuntu update history is ok
- promoting this does not seem to cause issues for MOTUs that so far
maintained the package
- no massive Lintian warnings
- debian/rules is rather clean
- It is not on the lto-disabled list
Problems:
- The current release is not packaged, but we are not much behind.
The new only has a small bugfix, worth to give it a try but no hard
requirement (0.10.0 -> 0.10.1).
[Upstream red flags]
OK:
- no Errors/warnings during the build
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside
tests)
- no use of user nobody (only nfsnobody for actual nfs use)
- no use of setuid / setgid
- no important open bugs (crashers, etc) in Debian or Ubuntu
- no dependency on webkit, qtwebkit, seed or libgoa-*
- not part of the UI for extra checks
- no translation present, but none needed for this case (lib only)
Problems: None
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2061750
Title:
[MIR] python-s3transfer as indirect dependency of simplestreams
(simplestreams -> python-boto3 -> python-s3transfer)
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/python-s3transfer/+bug/2061750/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
