1/ d/changelog should refer to oracular now, not noble
2.
+# XXX: Is there a better way to get the port number other than by parsing the
+# configuration file?
+port=$(sed -n '/^port=[0123456789]/{s/port=//p;q;}' /etc/xrdp/xrdp.ini)
Does the port change randomly, or is it always 3389 on a fresh install?
3.
+if test -n "$port"; then
+ exit 1
+fi
I think you meant "test -z" instead.
+timeout 29s xvfb-run -l xfreerdp /v:localhost:"$port" /p: /u: /d:
+if test $? != 124; then
+ 2>&1 printf "%s\n" "Xfreerdp exited before the timeout, it has likely " \
+ "failed to connect. The test has therefore failed."
+ exit 2
Ok, this is a new type of test :). You are actually counting on the
timeout command killing the binary for the test to succeed.
I'm not sure paride understood that before when he asked to increase
this timeout. I think your original 4s was ok, because a failure to
start should be quick.
I'm wondering if there is something else we could do here, but I don't
think there are text-mode rdp clients out there ;) Do you know of
something else that could exercise this rdp service at least a little
bit more? Perhaps some auth negotiation? I'll leave that up to you to
think about while you address the other points above, and it's not a
blocker if there isn't anything else to add here that would be simple
enough, yet give us a better idea of how well the package is working.
** Changed in: freerdp2 (Ubuntu)
Assignee: (unassigned) => Nathan Teodosio (nteodosio)
** Changed in: freerdp2 (Ubuntu)
Status: New => In Progress
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2060976
Title:
Create autopkgtest
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/freerdp2/+bug/2060976/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
