The test plan needs adjusting, as the apt-news hook does not log to "apt-news.service.txt", but sends stdout/stderr to /dev/null. And the apt-esm-json-hook invocation is the one that logs to /var/log/ubuntu- advantage-apt-hook.log.
Please also include in the test plan a logrotation scenario, i.e., something like: ls -la /var/log/ubuntu-advantage*.log logrotate -f /etc/logrotate.conf # Confirm rotation of non-zero logs, and zero logs are not rotated ls -la /var/log/ubuntu-advantage*.log # Write something to /var/log/ubuntu-advantage-apt-hook.log (would be best if you could make apt-esm-json-hook output something to stderr on apt-get upgrade) echo hello > /var/log/ubuntu-advantage-apt-hook.log # trigger rotation one more time logrotate -f /etc/logrotate.conf # confirm this time it was rotated ls -la /var/log/ubuntu-advantage*.log Also check if collect-logs will include this new log file (if that's the intention: I think it is, but I didn't check this in pre-review). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2074211 Title: Consider hiding error messages in apt-news.service to avoid being percived as "pro is broken" To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2074211/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
