Hi Simon, Thanks for the all work on this. This seems almost good to go for release, but I wanted to check 3 points with your first.
1) Are these uppercase messages expected by default? They seem unrelated to the proposed changes; just checking. uppercase messages by default? + groupadd --extrausers extragroup ENTER EXTRAUSERS_GROUP_FILEEXIT EXTRAUSERS_GROUP_FILEENTER EXTRAUSERS_SHADOWGROUP_FILEEXIT EXTRAUSERS_SHADOWGROUP_FILE+ useradd --extrausers --groups extragroup extrauser + groupadd --extrausers extragroup2 ENTER EXTRAUSERS_GROUP_FILEEXIT EXTRAUSERS_GROUP_FILEENTER EXTRAUSERS_SHADOWGROUP_FILEEXIT EXTRAUSERS_SHADOWGROUP_FILE+ useradd --extrausers --groups extragroup2 extrauser3 2) There's a small difference in the test steps executed (comment #12) vs. in bug description: Executed: + mount -o bind,ro /etc-rw /etc + groupadd --extrausers extragroup2 ENTER EXTRAUSERS_GROUP_FILEEXIT EXTRAUSERS_GROUP_FILEENTER EXTRAUSERS_SHADOWGROUP_FILEEXIT EXTRAUSERS_SHADOWGROUP_FILE+ useradd --extrausers --groups extragroup2 extrauser3 + id extrauser3 + grep extragroup2 uid=1004(extrauser3) gid=1008(extrauser3) groups=1008(extrauser3),1007(extragroup2) [Test Plan]: mount -o bind,ro /etc-rw /etc # ok groupadd --extrausers extragroup2 # ok useradd --extrausers --groups etcgroup extrauser3 # etcgroup vs extragroup2 id extrauser4 | grep etcgroup # extrauser4 vs extrauser3 (typo?) That is, the Test Plan uses `etcgroup`, which I guess is possibly to go through the code path that locked /etc/group and failed as described in [Impact]. Could you please confirm/clarify? 3) Other than the above, do you consider this is good for release? Specifically, can we consider verification-done-noble based on comment #18 from Ubuntu Core team _and_ your clarification above? Thank you! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2063200 Title: useradd --extrausers --groups tries to lock /etc/group To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/shadow/+bug/2063200/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
