I did a quick comparison between the build flags, using the first
compiler command line from the build log, when it's building now.o:
--- noble-devel 2024-11-28 15:36:33.478894133 -0300
+++ noble-unapproved 2024-11-28 15:36:28.490813597 -0300
@@ -24,13 +24,18 @@
-D_REENTRANT=1
-DXP_UNIX=1
-fcf-protection
+-fdebug-prefix-map=/home/ubuntu/git/packages/nspr/nspr=/usr/src/nspr-2:4.35-1.1ubuntu1~24.04
+-ffat-lto-objects
+-ffile-prefix-map=/home/ubuntu/git/packages/nspr/nspr=.
+-flto=auto
-fno-inline
+-fno-omit-frame-pointer
-fPIC
-fstack-clash-protection
-fstack-protector-strong
-g
+-mno-omit-leaf-frame-pointer
-O2
--pipe
-pthread
-UDEBUG
-UHAVE_CVAR_BUILT_ON_SEM
We do see the expected frame pointer flags, but also:
- LTO is now enabled
- debug and file prefix maps. I think this affects debugging, perhaps debug
symbols, but I'm not sure about the impact.
Enabling LTO in an LTS release like this could be concerning. There are
plenty of cases where LTO had to be disabled in the archive (just look
at the lto-disabled-list package).
Do we really need to enable LTO in this SRU? If yes, what is the test
plan for that kind of change? I think an upload just enabling frame
pointers would be more acceptable.
** Changed in: nspr (Ubuntu)
Status: New => Incomplete
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2084460
Title:
[SRU] Please enable frame-pointer on Noble
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/nspr/+bug/2084460/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
