Accepting, but with some comments for the future/next time:

a) d/watch is not working in focal and jammy, just noble. I was able to
verify the source by downloading the tarball and building the source
package in F, J, and N, and no discrepancies were found. A diff between
all these F, J, N uploads, and plucky, shows no source code differences,
just debian/*.

b) this change in jammy just talks about DEP3 fixes, but in fact it's pulling 
in a new hunk to the patch:
diff --git a/debian/patches/disable_udev_overrides.patch 
b/debian/patches/disable_udev_overrides.patch
index 7c344d0..11fc45a 100644
--- a/debian/patches/disable_udev_overrides.patch
+++ b/debian/patches/disable_udev_overrides.patch
@@ -1,3 +1,18 @@
+Description: Remove udev overrides in setup.py
+Forwarded: not-needed
+Author: Calvin Mwadime Makokha <[email protected]>
+--- a/setup.py
++++ b/setup.py
+@@ -82,8 +82,7 @@
+ 
+ def set_udev_files(data_files, dest="/etc/udev/rules.d/", src=None):
+     if src is None:
+-        src = ["config/66-azure-storage.rules",
+-               "config/99-azure-product-uuid.rules"]
++        src = []
+     data_files.append((dest, src))
+ 
+ 
 --- a/bin/waagent2.0
 +++ b/bin/waagent2.0
 @@ -95,8 +95,7 @@

The d/changelog entryu for this in jammy is:
      + d/p/disable_udev_overrides.patch: Refresh patch for making it
        DEP-3 compliant.

The above is definitely not just a refresh. The same change is in
noble+, though, and it works because d/install is installing those
files. In focal the d/changelog gives a bit more information:

      + d/p/disable_udev_overrides.patch: Adapt patch and making it
        DEP-3 compliant.

But still, I would have preferred a better changelog entry for this, to
make sure it's intended. I found this commit:

commit 63943d055109368dfd7f82f8276dd94301abbb46
Author: Calvin Mwadime <[email protected]>
Date:   Fri Nov 24 14:31:43 2023 +0300

    disable_udev_overrides.patch: Remove udev overrides in setup.py
    
    Already added udev rules in debian/install thus no need
    for overrides in setup.py

So that explains why setup.py is being patched.


** Changed in: walinuxagent (Ubuntu Noble)
       Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2068021

Title:
  MRE updates of walinuxagent 2.11.1.4 into N/J/F

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/walinuxagent/+bug/2068021/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to