> not doing it now it implies that all next cherry-picks will be more annoying to do and more risky
Oh come on. You're adding some device IDs, that's all. Fixing a merge conflict will take all of one minute, and the result will be easily reviewable. I *think* you're just adding two, since that's what the bug says, but I cannot easily tell from the diff because you've reordered them. Not being able to easily review this change is what is risky. On the other hand, I just spent ten minutes trying to get some confidence that reordering will not change behaviour, and I'm only about three levels of indirection and code generators deep so far. I'm not convinced that re-ordering has been shown not to change behaviour, and so in my opinion there's too much unnecessary risk here. I'm going to follow https://documentation.ubuntu.com/sru/en/latest/howto/common- issues/#upload then, and conclude that this needs fixing to the minimal cherry-pick. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2097831 Title: Support Synaptics fingerprint device with ID 06cb:0107 and 06cb:0108 To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/2097831/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
