> And in that case, why isn't the patch adjusting the test suite? Apparently you can add these IDs without the test suite needing adjusting, so it seems to me that you can remove IDs without causing the test suite to fail either, no?
The test suite checks that the IDs listed in both places are matching, so the test suite is updated implicitly, because the data that feeds it is the stuff you're seeing in the patch. And if one of the IDs was missing in a place or the other, then it would fail. So the cross check already happens. Thus any further human check isn't really needed. > Oh come on. You're adding some device IDs, that's all. Fixing a merge conflict will take all of one minute, and the result will be easily reviewable. I *think* you're just adding two, since that's what the bug says, but I cannot easily tell from the diff because you've reordered them. Not being able to easily review this change is what is risky. Honestly I think it's way more risky for the whole ubuntu to think that an SRU team member can't review and figure out what changed looking to a very tiny diff in which *5 simple lines* of a list (so it's not either code where order may matter) have been moved around. And despite what the docs says (indeed they should be reconsidered) about minimal patches, IMHO it's always worse to put in ubuntu a patch that is not also upstream for multiple reasons: - Hard to reiterate on it - Create more and more technical debt - Not the fix that has been technically been already released in the devel ubuntu version However, this is not the place to discuss this, but it's absurd that we've to both lose an undefined extra amount of time for things that are really a non-issues. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2097831 Title: Support Synaptics fingerprint device with ID 06cb:0107 and 06cb:0108 To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/2097831/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
