Regarding the SRU paperwork: 1. Please explain why this change is not needed for plucky or oracular, and then update the bug tasks accordingly.
2. The "test plan" currently reads more like an "impact" section. All of the information there is helpful, but please re-arrange so that the "impact" and "test plan" sections contain the relevant details. Regarding the upload itself: 1. There is a change to a bug number in the previous changelog entry, which does not seem appropriate: diff --git a/debian/changelog b/debian/changelog index 919efd5..2e816b9 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,7 +1,15 @@ +cd-boot-images-riscv64 (12.2) noble; urgency=medium + + * d/rules: Use "echo 'search.file /.disk/info root' > tree/EFI/boot/grub.cfg" + to find correct rootfs, as now debian-cd builds risc-v ISOs and does + not set disk label to 'live-media' as it used to. (LP: #2104572) + + -- Adriano Cordova <[email protected]> Thu, 27 Mar 2025 16:02:55 -0300 + cd-boot-images-riscv64 (12.1) noble; urgency=medium * Rebuild against grub2 2.12-1ubuntu7.1 and u-boot 2024.01+dfsg-1ubuntu5.1 - (LP: #2062166) + (LP: #2096766) -- Mate Kukri <[email protected]> Mon, 27 Jan 2025 14:10:02 +0000 I realize from looking at these two bug numbers that there was a mistake at the time 12.1 was uploaded. However, that mistake was noted accordingly on the bugs, and at this point, it would be better to leave the previous changelog entry alone. Please remove that change. 2. In the "where problems could occur" section, it is said that: > The rootfs should be the only filesystem in the image containing a file named > /.disk/info. If not, we risk loading an incorrect filesystem. However, I see no attempt to mitigate this in the proposed patch. Is there safeguard that should be added to this logic? If not, can you expand the "where problems could occur" section to explain why, despite that risk, this is the way the patch is written? ** Changed in: cd-boot-images-riscv64 (Ubuntu Noble) Status: New => Incomplete ** Changed in: cd-boot-images-riscv64 (Ubuntu) Status: New => Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2104572 Title: Booting the daily noble RISC-V installer image fails To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cd-boot-images-riscv64/+bug/2104572/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
