Please amend the test plan with a check to confirm that the existing *.list files are also renamed, not just the *.sources types.
** Description changed: [Impact] * Currently, as reported above, Landscape repository profiles only act upon .list files while .sources remain in effect. As Noble transitioned from the default source definition being the traditional .list files to DEB822 .sources files, this bug manifested when a customer noticed sources that they wanted disabled were still appearing in apt update. * The determined solution was to add pattern matching for .sources extensions as well as .list files. Merged PR here: https://github.com/canonical/landscape-client/pull/298 * The first LTS to support DEB822 .sources was Xenial, however, the first LTS where this format became the default was noble. The proposed SRU is to bring this change back to Focal [Testing] - * To reproduce the problem, apply a repository profile on a Noble - machine and observe that it does not migrate .sources files to + * To reproduce the problem, apply a repository profile on an affected + ubuntu system and observe that it does not migrate .sources files to .sources.save by listing /etc/apt/sources.list.d/, and running apt update to see that the sources are still being used * Apply the patch and apply a Landscape profile, noting that .sources files successfully move to .sources.save and no longer appear in the output of apt update [What can go wrong] * The change is rather localized and brief, so it is not expected to introduce any regressions or problems. Applying a profile may take more time due to extra pattern matching and checking - particularly is the filesystem has many .sources files - [Original Description] Somewhat related to LP:2062561, landscape-client currently only appends .save to source lists ending in .list, which leaves 822 style lists using the .sources extension intact. This means that applying a repository profile to any machine using the new .sources files will still have their public repository sources enabled after a repository profile is applied. https://github.com/canonical/landscape- client/blob/main/landscape/client/manager/aptsources.py#L144 This was reported 2024-11-08 internally, and now also reported by a customer in case:00400550 ** Description changed: [Impact] * Currently, as reported above, Landscape repository profiles only act upon .list files while .sources remain in effect. As Noble transitioned from the default source definition being the traditional .list files to DEB822 .sources files, this bug manifested when a customer noticed sources that they wanted disabled were still appearing in apt update. * The determined solution was to add pattern matching for .sources extensions as well as .list files. Merged PR here: https://github.com/canonical/landscape-client/pull/298 * The first LTS to support DEB822 .sources was Xenial, however, the first LTS where this format became the default was noble. The proposed SRU is to bring this change back to Focal [Testing] * To reproduce the problem, apply a repository profile on an affected ubuntu system and observe that it does not migrate .sources files to .sources.save by listing /etc/apt/sources.list.d/, and running apt update to see that the sources are still being used - * Apply the patch and apply a Landscape profile, noting that .sources - files successfully move to .sources.save and no longer appear in the - output of apt update + * Upgrade to the landscape-client packages from proposed and apply a + Landscape profile, noting that .sources files successfully move to + .sources.save and no longer appear in the output of apt update [What can go wrong] * The change is rather localized and brief, so it is not expected to introduce any regressions or problems. Applying a profile may take more time due to extra pattern matching and checking - particularly is the filesystem has many .sources files [Original Description] Somewhat related to LP:2062561, landscape-client currently only appends .save to source lists ending in .list, which leaves 822 style lists using the .sources extension intact. This means that applying a repository profile to any machine using the new .sources files will still have their public repository sources enabled after a repository profile is applied. https://github.com/canonical/landscape- client/blob/main/landscape/client/manager/aptsources.py#L144 This was reported 2024-11-08 internally, and now also reported by a customer in case:00400550 ** Changed in: landscape-client (Ubuntu Oracular) Status: In Progress => Fix Committed ** Tags added: verification-needed verification-needed-oracular -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2087852 Title: [FFe][SRU] Repository profiles only act on .list files and do not affect .source files To manage notifications about this bug go to: https://bugs.launchpad.net/landscape-client/+bug/2087852/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
