0006-common-add-led.conf-with-SetLED-macro-to-hide-implem.patch adds a new setled macro, and 0007-ucm2-use-new-SetLED-macro-to-hide-the- implementation.patch starts using it for many chipsets, not just cs42l43 and cs35l56.
This introduces a chance of regression for other hardware, not just the one intended for this SRU. I suppose that change isn't really needed, and was pulled in just to make the follow-up patches apply. I.e., the fix for LED support in cs42l43 and cs35l56 is using the new macro, as can be seen in 0009-sof-soundwire-Add-LED-support-for- cs35l56-amplifiers.patch Have you considered only making cs42l43 and cs35l56 use the new macro? Patch 0007-ucm2-use-new-SetLED-macro-to-hide-the-implementation.patch is currently also making rt5640, rt5672, rt715, rt722 use it, from what I could see. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2106394 Title: [SRU] enable cs42l43 and cs35l56 audio on Intel LNL To manage notifications about this bug go to: https://bugs.launchpad.net/hwe-next/+bug/2106394/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
