Thanks for the review! > d/copyright: nitpick: traditionally we have a separate paragraph for debian/* (some tooling expect it), even if it uses the same license as the default.
Makes sense, will fix it in the next revision! > hwids/txt,json: question (not-blocking): AFAICT the json is generated from the txt, could you please do that at build time rather than shipping them as-is? Preferred form of modification and all that... Partly. Generating will currently insert a FIXME for the compatible which won't work so that wasn't an option. The README explains that: > The `.txt` files in hwids/txt have been generated with `fwupdtool hwids`. > The can be converted to `.json` files by running `hwid2json.py` from the > `hwids` directory. The `compatible` field of the resulting JSON files has > to be filled in manually. We could consider having those hard coded in some other form and combining that and the generated json automatically. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2119319 Title: [needs-packaging] ubustub To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/2119319/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
