Thank you Wesley!
Indeed the case suggests to just drop this considering this setting an
old artifact.
On one hand we have your pretty good argument of the default of
`requiretty` being false in classic sudo and `!requiretty` means setting
it to false. So dropping it should be no functional change.
Further we have discussed and tracked this change to come from the very first
days of cinder as a package.
In 2012 there is "* debian/{cinder_sudoers, rules, cinder-common.install}:
Install proper cinder_sudoers."
No one seems to just remember why it was added.
But a bit more archaeology made me find [1]
And that made me suspicious which made me find [2]
And similar [3] into [4]
So they all add it the same way, but later resolve and drop the respective
options [4].
They also use other options but that is for another day to be considered.
We can take away from is that others showed it working without !requiretty for
a while already which is another +1 on dropping it here.
So with the breakage present, the fact that it should be a no-op, and others
showing it seems to work without - I think it is time to drop this line.
Adding a Cinder bug task to please do so unblocking many things waiting for
these tests.
[1]:
https://build.opensuse.org/projects/Cloud:OpenStack:Zed/packages/openstack-cinder/files/openstack-cinder.sudoers?expand=1
[2]:
https://opendev.org/openstack/rpm-packaging/src/commit/f7bf23466a2bd5c6153cca0dec96f8886405e1d5/openstack/cinder/openstack-cinder.sudoers
[3]:
https://opendev.org/openstack/rpm-packaging/commit/51df718d14773d1c06274b07d60a2842c9483471
[4]:
https://opendev.org/openstack/rpm-packaging/commit/2283414ad6e5fa1192e72358268c24b026b76e4f
** Also affects: cinder (Ubuntu)
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2120708
Title:
Incompatible/Missing requiretty setting
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cinder/+bug/2120708/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
