Hi,

A couple notes on the jammy upload.

1. The new upload unnecessarily (AFAICT) modifies the patch added in the
previous upload:

$ git show queue/jammy/unapproved/c385f35 --stat
tag queue/jammy/unapproved/c385f35
Tagger: Nick Rosbrook <[email protected]>
Date:   Wed Sep 3 11:46:37 2025 -0400

Launchpad-URI:
https://api.launchpad.net/devel/ubuntu/jammy/+upload/36463995

commit c385f3591c9f7752e1ed6e5f8fdcc91df28d4c34 (tag: 
queue/jammy/unapproved/c385f35)
Author: Dariusz Gadomski <[email protected]>
Date:   Wed Sep 3 11:29:29 2025 +0200

    Queue import

 debian/changelog                |   6 ++++++
 debian/patches/bug2110614.patch | 195 
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 debian/patches/lp2110614.patch  | 195 
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 debian/patches/series           |   2 +-
 debian/rules                    |   3 ++-
 5 files changed, 204 insertions(+), 197 deletions(-)

If this is somehow necessary, it needs to be called out in the
changelog. But, assuming it is unnecessary, the patch should be left
alone.

2. Related to debian/rules:

diff --git a/debian/rules b/debian/rules
index 853eeb1..b8d0389 100755
--- a/debian/rules
+++ b/debian/rules
@@ -7,6 +7,7 @@ export LANG=C
 export TZ=GMT
 
 include /usr/share/dpkg/buildflags.mk
+include /usr/share/dpkg/pkg-info.mk
 
 export CCFLAGS+=$(shell dpkg-buildflags --get CFLAGS)
 export CCFLAGS+=$(shell dpkg-buildflags --get CPPFLAGS)
@@ -35,7 +36,7 @@ override_dh_installchangelogs:
 
 override_dh_gencontrol:
        dh_gencontrol --package=ksh93u+m
-       dh_gencontrol --package=ksh -- -v20211217
+       dh_gencontrol --package=ksh -- -v20240113-$(DEB_VERSION)
 
 clean:
        dh_testdir

This should probably only *append* the $(DEB_VERSION), not update the
existing version.

These issues need to be fixed, and I am rejecting the jammy upload for
that reason.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2117103

Title:
  Hardcoded version in debian/rules breaks new uploads

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ksh93u+m/+bug/2117103/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to