Hello and thank you for the great review. A few comments, and questions.
- About the version: 1.4.321 is the version that is aligned with what is in the archive right now. Also there is a new version every 3 month or so and I'm afraid if I update to .328 already, by the time the sponsoring it done it will be old too. Is it fine to push .321 version for now? - I fixed the versioning, changelog, maintainer. - I fixed the git linked. However the provided launchpad link is a personal repo, not a ubuntu/+source/ one. I assume that will change later? - About the manual, I was mimic'ing the packages spirv-headers, spirv- tools, that don't have manuals. The GitHub readme is the manual. Shall copy an past it in the manual? Or provide a link? Or don't publish a manual? - I fixed the lintian issues (except the manual the above) - I added google tests. I see that I can build the tests with -DSPIRV_REFLECT_BUILD_TESTS=ON but running them would be an addition command. Does that still make it a build-time test? If yes, what would be autopkg-tests about? > Maybe split into spriv-reflect package with utilities, libspriv- reflect with a library and libspriv-reflect-dev with headers. I wanted to have this package close to the packaging that lunarG was providing before: https://packages.lunarg.com/vulkan/1.4.313/pool/main/s/spirv-reflect/ They hold more business knowledge than me (they are the upstream maintainers) so I assume they were doing this right. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2127243 Title: [needs-packaging] spirv-reflect To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/2127243/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
