Hi, > - About the version: 1.4.321 is the version that is aligned with what is in the archive right now. Also there is a new version every 3 month or so and I'm afraid if I update to .328 already, by the time the sponsoring it done it will be old too. Is it fine to push .321 version for now?
This is a default requirement from the new package review [1]. If it is not very hard it would be nice to have the latest upstream. > I fixed the git linked. However the provided launchpad link is a personal repo, not a ubuntu/+source/ one. I assume that will change later? We can put a link to ubuntu/+source/ - that's completely fine. > - About the manual, I was mimic'ing the packages spirv-headers, spirv- tools, that don't have manuals. The GitHub readme is the manual. Shall copy an past it in the manual? Or provide a link? Or don't publish a manual? Oh, a properly formatted manual would be extremely nice, but as the bare minimum we should do help2man, e.g. like here[2] - I added google tests. I see that I can build the tests with -DSPIRV_REFLECT_BUILD_TESTS=ON but running them would be an addition command. Does that still make it a build-time test? If yes, what would be autopkg-tests about? If dh_auto_test is not picking them up, we can do something like override_dh_auto_test: (cd build && ./test-spirv-reflect) dh_auto_test For autopkgtests we can do the python tests with spirv database (like upstream does in ci). > They hold more business knowledge than me (they are the upstream maintainers) so I assume they were doing this right. Yes and no =) normally the packages are split, but we have quite a few examples of the opposite. So lets rename binary package to spriv-reflect (since its providing utilities). Also I wonder why we package static library if upstream does not do it? [1] https://wiki.ubuntu.com/UbuntuDevelopment/CodeReviews#NewPackage [2] https://git.launchpad.net/ubuntu/+source/jtreg7/tree/debian/rules?h=ubuntu/questing#n59 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2127243 Title: [needs-packaging] spirv-reflect To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/2127243/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
