** Description changed: [ Impact ] As part of the fix to 2107604, in version 37, the client started using fcntl to get the apt lock once it's released at the end of do-release-upgrade. The problem is that it does not release the lock, and calls apt in a subprocess to perform service disablement when needed. Because the lock is held by the client, apt can never run. Attached users which do a release upgrade will then end up with services enabled when they should not. This may not be a critical issue, but can cause real problems, and it's a regression. The fix is simple: the client must release the lock as soon as it's locked. Being able to acquire the lock means apt has finished the chunk of work in the release upgrade. [ Test plan ] - There are upgrade tests in the Pro Client CI, and the failures in the SRU verification for version 37 catched this bug. + There are upgrade tests in the Pro Client CI, and the failures in the SRU verification for version 37 caught this bug. The plan is to run all upgrade tests in the CI and make sure they all pass, and there are no errors in the do-release-upgrade hook. [ Where problems could occur ] If another process grabs the lock after the Client releases it, then APT won't be able to modify sources when disabling the services. However, that's unlikely, as it will happen right at the end of do-release- upgrade. If it happens, APT itself will retry for a while without erroring out. This is acceptable, and it's the behavior up to version 36 (although the lock check there was wrong, the same situation with APT would happen).
-- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2129712 Title: [SRU] Pro Client version 37 does not run the post do-release-upgrade hook To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2129712/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
