@binli, thanks for the new debdiff. That helps a bit, but I am still confused by the many changes. I will use the changelog diff to explain:
diff -Nru alsa-ucm-conf-1.2.12/debian/changelog alsa-ucm-conf-1.2.12/debian/changelog --- alsa-ucm-conf-1.2.12/debian/changelog 2025-10-23 03:10:20.000000000 +0000 +++ alsa-ucm-conf-1.2.12/debian/changelog 2025-12-18 02:41:38.000000000 +0000 @@ -1,3 +1,82 @@ +alsa-ucm-conf (1.2.12-1ubuntu2.2) questing; urgency=medium + + [ Kai-Chuan Hsieh ] + * Support Realtek audio solution ALC3329B+ALC1708B (LP: #2129952) + - d/p/lp2129952/0001-ucm2-sof-soundwire-add-rt712-VA-device.patch + - d/p/lp2129952/0001-ucm2-sof-soundwire-add-rt712-vb-device.patch + - d/p/lp2129952/0001-ucm2-sof-soundwire-add-rt721-ucm-support.patch + - d/p/lp2129952/0001-ucm2-sof-soundwire-support-rt713vb-codec.patch + - d/p/lp2129952/0001-ucm2-rt712-simplify-the-init-settings.patch + - d/p/lp2129952/0001-sof-soundwire-fix-for-sdca-variants-for-multi-codec.patch + - d/p/lp2129952/0001-sof-soundwire-second-fix-for-sdca-variants-for-multi.patch + - d/p/lp2129952/0001-rt713-add-mic-led-support.patch + - d/p/lp2129952/0001-sof-soundwire-third-fix-for-multi-codec.patch + - d/p/lp2129952/0001-ucm2-codecs-rt722-add-condition-to-SetLED-for-mic.patch Okay. These all make sense. The changelog is clear in explaining that these patches apply to *this* bug, and the patches are organized as such. Great. + + [ Bin Li ] + * Some patches are missing in Questing. (LP: #2130313) + The initial version of the patch was uploaded 1.2.12-1ubuntu2 under + lp:2100732, but the fix(lp:2106394) was revised twice afterwards. + Unfortunately, we missed carrying the final/revised fixes forward. + + https://bugs.launchpad.net/ubuntu/+source/alsa-ucm-conf/+bug/2106394 + + https://bugs.launchpad.net/ubuntu/+source/alsa-ucm-conf/+bug/2100732 + + Drop duplicate patches: + - d/p/0004-rt722-add-mic-led-support.patch According to this changelog entry, this patch is dropped, but I still see it after applying the patch. And, if it is duplicate, what's the duplicate? + + Orgnize patches: typo: Orgnize -> Organize. Also, I am not sure this stanza is even necessary. It adds a lot of noise to the changelog, especially since all of these patches are referenced again below (though with outdated paths). + - d/p/lp2130313/0001-sof-soundwire-Add-missing-match-for-cs42l43-speakers.patch + - d/p/lp2130313/0002-sof-soundwire-Add-support-for-cs42l43-cs35l56-bridge.patch + - d/p/lp2130313/0001-sof-soundwire-Change-map-control-names-to-make-them-.patch + - d/p/lp2130313/0002-sof-soundwire-Add-sequence-for-controlling-Mic-Mute-.patch + - d/p/lp2130313/0001-sof-soundwire-cs42l43-spk-Correct-PlaybackPCM-and-ro.patch + - d/p/lp2130313/0002-sof-soundwire-cs42l43-Correct-CapturePCM-and-routing.patch + - d/p/lp2130313/0003-ucm2-sof-soundwire-Correct-FixedBootSequence-for-dmi.patch + - d/p/lp2130313/0004-sof-soundwire-Split-cs42l43-dmic-initialisation.patch + - d/p/lp2130313/0005-sof-soundwire-Fix-cs42l43-dmic-initialisation.patch + - d/p/lp2130313/0006-common-add-led.conf-with-SetLED-macro-to-hide-implem.patch + - d/p/lp2130313/0007-ucm2-use-new-SetLED-macro-to-hide-the-implementation.patch + - d/p/lp2130313/0008-sof-soundwire-cs42l43-Drop-headset-mic-from-mic-mute.patch + - d/p/lp2130313/0009-sof-soundwire-Add-LED-support-for-cs35l56-amplifiers.patch + - d/p/lp2130313/0010-sof-soundwire-cs42l43-Switch-mixer-based-on-output-v.patch + + [ Atlas Yu ] + * Fix file mode of amd-soundwire.conf (LP: #2106394) + amd-soundwire.conf should be a symlink to sof-soundwire.conf + + * Import patches that have already been applied to noble and oracular, + but not yet to plucky. This and previous uploads are dependent on + these patches. (LP: #2069760) + - d/p/0001-sof-soundwire-Add-missing-match-for-cs42l43-speakers.patch + - d/p/0002-sof-soundwire-Add-support-for-cs42l43-cs35l56-bridge.patch + - d/p/0001-sof-soundwire-Change-map-control-names-to-make-them-.patch + - d/p/0002-sof-soundwire-Add-sequence-for-controlling-Mic-Mute-.patch + - d/p/0004-rt722-add-mic-led-support.patch This sounds outdated. You mean "not yet to questing", right? But isn't this whole stanza redundant with the "Some patches are missing in Questing" stanza above? + + * Add LED support for cs42l43 and cs35l56 (LP: #2106394) + Some inapplicable patches were dropped in the previous upload. Now + we include all its dependencies to make it work. This sounds like old context (from the plucky SRU or something). Can we just talk about things as they relate to questing, right now? + + Drop: + - d/p/0001-sof-soundwire-Add-LED-support-for-cs35l56-amplifiers.patch Why is this here? This patch is not dropped by the debdiff. + + Some upstream commits got modified due to contextual changes. + Add: + - d/p/0001-sof-soundwire-cs42l43-spk-Correct-PlaybackPCM-and-ro.patch + - d/p/0002-sof-soundwire-cs42l43-Correct-CapturePCM-and-routing.patch + - d/p/0003-ucm2-sof-soundwire-Correct-FixedBootSequence-for-dmi.patch + - d/p/0004-sof-soundwire-Split-cs42l43-dmic-initialisation.patch + - d/p/0005-sof-soundwire-Fix-cs42l43-dmic-initialisation.patch + - d/p/0006-common-add-led.conf-with-SetLED-macro-to-hide-implem.patch + - d/p/0007-ucm2-use-new-SetLED-macro-to-hide-the-implementation.patch + - d/p/0008-sof-soundwire-cs42l43-Drop-headset-mic-from-mic-mute.patch + - d/p/0009-sof-soundwire-Add-LED-support-for-cs35l56-amplifiers.patch + - d/p/0010-sof-soundwire-cs42l43-Switch-mixer-based-on-output-v.patch I am not sure this is very helpful to have in the changelog. If you want to add this kind of note, please add it to the patch itself, where it will be useful to someone reading the patch. + + -- Bin Li <[email protected]> Thu, 18 Dec 2025 10:41:38 +0800 + On a practical note, what bugs do you plan to include in the SRU process? This (bug 2129952) sounds like its own thing, so that's fine. But you also reference bug 2069760, bug 2106394, and bug 2130313. All of these are some version of "add support for cs42l43 and cs35l56". Do you actually plan to do the SRU verification for each one separately? Or, since the real bug is "support for cs42l43 and cs35l56 was missed for questing", should everything continue in bug 2130313? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2129952 Title: Support for Realtek audio solution ALC3329B+ALC1708B on new Dell PTL platform To manage notifications about this bug go to: https://bugs.launchpad.net/hwe-next/+bug/2129952/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
