Review for Source Package: dput-ng
[Summary]
dput-ng is a clean, well-maintained pure Python package with no significant
issues found across any of the reviewed sections. All runtime dependencies are
already in main (with debian-keyring correctly demoted to Suggests), there is
no embedded or vendored code, no static linking, and no Built-Using entries.
The security posture is straightforward — it's a CLI upload tool that runs as
the invoking user, opens no ports, installs no services, and delegates all
cryptographic work to the system gpg binary. It has a build-time test suite and
a passing autopkgtest, builds cleanly, and the Ubuntu delta from Debian is
minimal and well-justified.
MIR team ACK. Please subscribe ~debcrafters before promotion.
This does not need a security review.
List of specific binary packages to be promoted to main: dput-ng, python3-dput
Specific binary packages built, but NOT to be promoted to main: dput-ng-doc
Notes:
Recommended TODOs:
- The package should get a team bug subscriber before being promoted
[Rationale, Duplication and Ownership]
There is no other package in main providing the same functionality - This
package has the intention of replacing the existing dput as is a newer rewrite
and has certain functionality that is desirable for Ubuntu.
A team is committed to own long term maintenance of this package. (~Debcrafters)
The rationale given in the report seems valid and useful for Ubuntu.
[Dependencies]
- no other runtime Dependencies to MIR due to this
- no other build-time Dependencies with active code in the final binaries
to MIR due to this
- no -dev/-debug/-doc packages that need exclusion
- No dependencies in main that are only superficially tested requiring
more tests now.
Problems: None
[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking
- does not have unexpected Built-Using entries
OK:
- not a go package, no extra constraints to consider in that regard
- not a rust package, no extra constraints to consider in that regard
- Does not include vendored code
Problems: None
[Security]
OK:
- history of CVEs does not look concerning
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not parse data formats (files [images, video, audio,
xml, json, asn.1], network packets, structures, ...) from
an untrusted source - parses user’s own .changes/.dsc file only. This is only
a client-side transport tool. The security enforcement for what actually gets
accepted lives on the archive side.
- does not expose any external endpoint (port/socket/... or similar) - outwards
only, no listening ports
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)
- does not deal with cryptography (en-/decryption, certificates,
signing, ...) - uses gpg for signature verification which is common and
appropriate
- this makes appropriate (for its exposure) use of established risk
mitigation features (dropping permissions, using temporary environments,
restricted users/groups, seccomp, systemd isolation features,
apparmor, ...)
Problems: None
[Common blockers]
OK:
- does not FTBFS currently
- does have a test suite that runs at build time
- test suite fails will fail the build upon error.
- does have a non-trivial test suite that runs as autopkgtest
- This does not need special HW for build or test
- no new python2 dependency
- Python package, but using dh_python
Problems: None
[Packaging red flags]
OK:
- Ubuntu does not carry a delta
- symbols tracking not applicable for this kind of code.
- debian/watch is not present but also not needed (e.g. native)
- Upstream update history is good
- Debian/Ubuntu update history is good
- the current release is packaged
- promoting this does not seem to cause issues for MOTUs that so far
maintained the package
- no massive Lintian warnings
- debian/rules is rather clean
- It is not on the lto-disabled list
Problems: None
[Upstream red flags]
OK:
- no Errors/warnings during the build
- no incautious use of malloc/sprintf (the language has no direct MM)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside
tests)
- no use of user 'nobody' outside of tests
- no use of setuid / setgid
- no important open bugs (crashers, etc) in Debian or Ubuntu
- no dependency on webkit, qtwebkit or libseed
- not part of the UI for extra checks
- no translation present, but none needed for this case.
Problems: None
** Changed in: dput-ng (Ubuntu)
Assignee: Myles Penner (mylesjp) => (unassigned)
** Changed in: dput-ng (Ubuntu)
Status: New => In Progress
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2138904
Title:
[MIR] dput-ng
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/dput-ng/+bug/2138904/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
