I had a look at the rocwmma package (taken from this ppa: https://launchpad.net/~tchavadar/+archive/ubuntu/lp2141514) and have some comments:
- There is a duplicate (well: threefold) description in d/control: "I: rocwmma source: duplicate-long-description librocwmma-dev librocwmma-docs librocwmma-tests [debian/control]" could be as this for now: " --- debian/control 2026-02-18 15:11:01.731457102 +0100 +++ ../control 2026-02-18 15:10:05.838626363 +0100 @@ -37,7 +37,6 @@ device code. This can benefit from compiler optimization in the generation of kernel assembly, and doesn't incur additional overhead costs of linking to external runtime libraries or having to launch separate kernels. - Headers section. Package: librocwmma-tests Architecture: amd64 arm64 @@ -52,7 +51,6 @@ device code. This can benefit from compiler optimization in the generation of kernel assembly, and doesn't incur additional overhead costs of linking to external runtime libraries or having to launch separate kernels. - Test section. Package: librocwmma-docs Architecture: all @@ -66,4 +64,3 @@ device code. This can benefit from compiler optimization in the generation of kernel assembly, and doesn't incur additional overhead costs of linking to external runtime libraries or having to launch separate kernels. - Documentation section. " - the quilt patches: d/p/0001-remove-unknown-compiler-options.patch d/p/0002-do-not-treat-doxygen-warnings-as-errors.patch d/p/0003-fix-arm64-mcmodel-large-failure.patch miss a dep-3 header. They can be added with: quilt header -e --dep3 0001-remove-unknown-compiler-options.patch # and so on ... - then I see this warning: "W: rocwmma source: debian-rules-calls-nproc [debian/rules:29]" Recommended is to use DEB_BUILD_OPTION_PARALLEL instead of nproc. (see: lintian-explain-tags debian-rules-calls-nproc) - scr code copyright-wise things seem to be very tidy and the code is MIT/Expat. But I see Canonical/Talha for copyright debian/* as MIT/Expat too, but I think the standard for Canonical is still GPL-3 (iianm): " Files: debian/* Copyright: 2018 Canonical Ltd License: GPL-3 This package is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; version 3 of the License. . This package is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. . You should have received a copy of the GNU General Public License along with this program. If not, see <https://www.gnu.org/licenses/> . On Debian systems, the complete text of the GNU General Public License version 3 can be found in "/usr/share/common-licenses/GPL-3". " - And there are two blank lines 5 and 6 in d/copyright - either or should be removed. - And I think that we usually have: "Maintainer: Ubuntu Developers <[email protected]>" in d/control. (maybe keeping the old one in "XSBC-Original-Maintainer:") - watch file is a v5, good - We have a library, but no symbols file(s), no? - The librocwmma-tests DEBs are (very) huge, with ~1.5GB. I strongly recommend to reach out to the AAs and let them know about the size. (I think at least in the past that could definitely have caused problems.) - Debian recommends names for documentation packages that have the suffix "-doc" (and not "-docs". The latter one leads to the lintian tag "I: librocwmma-docs: unusual-documentation-package-name". Probably worth to discuss with upstream this change. - and in d/control it would be recommended to set dedicated sections for the -de and the -doc(s) package like this: " Package: librocwmma-dev Section: libdevel ... Package: librocwmma-docs Section: doc " Otherwise 'devel' is assumed (from the src pkg) and lintian moans with "wrong-section-according-to-package-name". -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2141514 Title: [needs-packaging] rocwmma - in ubuntu To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/2141514/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
