Thanks for the pointers, Luciano!
I did an initial review, and those are the points I'd like to sort out:
- [Suggestion] The changelog entry for the new release is missing the LP
reference to this bug.
- [Suggestion] The changelog mentions several removals, both for patches and d/
changes. It would be good to add a brief justification for each of those
removals, to make it easier for future reviewers to understand the rationale
behind them. Something like:
* d/p/lp2080208.patch: Removed, no longer needed.
[ Fixed upstream in version X.Y]
- [Important] lintian is reporting warnings/errors for a few reasons, including
copyright information. Please run lintian against the source package and check
those. It would be nice to have d/copyright sane, even more as we are ahead of
Debian. If you check the lintian output and consider it fine, please add a
comment here.
- [Important] There are changes to d/control and d/rules not mentioned in the
changelog. I can see
d/rules
+ export CMAKE_POLICY_VERSION_MINIMUM = 3.5
d/control
- libboost-process-dev
- libboost-system-dev (>= 1.82.0)
+ libboost-process1.90-dev
- [Question] Is it intentional that the libboost-system-dev dependency was
removed?
- [Question] Is there a reason not to depend in the meta libboost-process-dev?
In resolute it will point to 1.90 anyway. Matthias has added a patch to the
current ceph version in ubuntu/devel to depend on the metapackage, I wonder if
we could do the same here. If the answer is that you need to specify the
version, wouldn't it be better to depend on libboost-process-dev (>= 1.90.0)
instead of the specific package?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2139385
Title:
Update Ceph to new 20.2.0 (Tentacle) version
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/2139385/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
