Chris and I had a quick look at this today. Unfortunately we did not have time for a full review. We did however have some comments:
dgx-desktop-pro-activation.sh This says "# SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved." which would imply we can't redistribute it. It uses fixed paths in /tmp. That's a bit of a no-no from a security POV. It uses efivar, jq and pro without any dependency declarations (indeed, I don't even have efivar installed on my laptop!). It seems to try to disable dgx-oobe-ubuntu-pro-activate.service when it runs, is that supposed to be it disabling itself? In general it feels like what this script is doing should be integrated into cloud-init somehow. dgx-desktop-docker-gpus.sh This should probably be a systemd generator? That writes to /run, not /etc. nvme-interrupt-coalescing.sh On first blush this looks like it should be a udev rule? zz-kdump-tools.cfg doesn't the installer do this now? Sorry to be so negative, hopefully we can get a full review done at some point. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2136865 Title: [needs-packaging] dgx-desktop-defaults To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/2136865/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
