Thank you for the review, What's tricky about this package is that it's mirrored from some nvidia- delivered recommendations which I hardened a little bit (not enough, as I understand!). Still I'm trying to keep these not too far from what NVIDIA says, because it's easier to maintain this way. That being said:
- The Depends are definitely a miss that I'll fix ASAP - dgx-desktop-pro-activation is confirmed to be MIT by Ken, per discussions with NVIDIA, so I'll make this one more in par with Ubuntu's quality standards. I can improve it. But do you think I should entirely remove it and do something in Subiquity instead? What we want is that users get pro activated on these devices even if they installed a newer ubuntu version from scratch in the future. NVIDIA burnt the pro token in an EFI variable for that, but that's uncommon. - dgx-desktop-docker-gpus.sh > Generators are small executables placed in /lib/systemd/system-generators/ > and other directories listed [below]. systemd(1) will execute these binaries > very early at bootup and at configuration reload time —before unit files are > loaded. I've never used generators before but yes, this feels less clunky than a service that runs on every boot while not waiting on any other target. - nvme-interrupt-coalescing.sh Why not also a generator? - zz_kdump-tools.cfg is meant to set the crashkernel memory to 0. linux-crashdump generates similar lines to reserve crashkernel memory dependending on the device's available RAM: ``` $ cat /etc/default/grub.d/kdump-tools.cfg GRUB_CMDLINE_LINUX_DEFAULT="$GRUB_CMDLINE_LINUX_DEFAULT crashkernel=2G-4G:320M,4G-32G:512M,32G-64G:1024M,64G-128G:2048M,128G-:4096M" ``` Nvidia wants it set to zero, and they want linux-crashdump to be installed by default on users machines. But since Ubuntu does not provide linux-crashdump by default, I can remove this binary package if you prefer. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2136865 Title: [needs-packaging] dgx-desktop-defaults To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/2136865/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
