Hi, I reviewed the the package currently in NEW, and I don't see blockers, d/copyright looks much better! I have however a few comments. There are a number of lintian tags which I would like not to see in a well maintained package:
--- I: ghostty source: debian-rules-contains-unnecessary-get-orig-source-target [debian/rules] I: ghostty source: debian-rules-parses-dpkg-parsechangelog [debian/rules:10] I: ghostty source: debian-rules-parses-dpkg-parsechangelog [debian/rules:6] I: ghostty source: license-file-listed-in-debian-copyright zig-vendor/gettext-N-V-__8AADcZkgn4cMhTUpIz6mShCKyqqB-NBtf_S2bHaTC-/gettext-tools/tree-sitter-0.23.2/lib/src/unicode/LICENSE [debian/copyright] I: ghostty source: license-file-listed-in-debian-copyright zig-vendor/gtk4_layer_shell-N-V-__8AALiNBAA-_0gprYr92CjrMj1I5bqNu0TSJOnjFNSr/LICENSE [debian/copyright] I: ghostty source: license-file-listed-in-debian-copyright zig-vendor/highway-N-V-__8AAGmZhABbsPJLfbqrh6JTHsXhY6qCaLAQyx25e0XE/LICENSE [debian/copyright] I: ghostty source: license-file-listed-in-debian-copyright ... use "--tag-display-limit 0" to see all (or pipe to a file/program) I: ghostty source: older-debian-watch-file-standard 4 [debian/watch] I: ghostty source: patch-not-forwarded-upstream [debian/patches/enforce-shell-integration-ssh-env.patch] I: ghostty source: unnecessary-source-date-epoch-assignment [debian/rules:10] I: ghostty source: unused-license-paragraph-in-dep5-copyright apsl-2.0 [debian/copyright:5942] I: ghostty source: unused-license-paragraph-in-dep5-copyright artistic-1.0 [debian/copyright:6868] I: ghostty source: unused-license-paragraph-in-dep5-copyright bsd-4-clause [debian/copyright:6364] I: ghostty source: unused-license-paragraph-in-dep5-copyright ... use "--tag-display-limit 0" to see all (or pipe to a file/program) I: ghostty source: unused-override source-contains-autogenerated-visual-c++-file * [debian/source/lintian-overrides:3] --- Not all of them are to be fixed or silenced (this is up to the package maintainer), but I believe that at least: - older-debian-watch-file-standard - unnecessary-source-date-epoch-assignment - unused-license-paragraph-in-dep5-copyright - unused-override - redundant-priority-optional-field (visible with pedantic verbosity level) should be easy to address. Moreover, I think all d/t/control tests but the `xvfb-run` one should be marked with: Restrictions: superficial as they don't really exercise ghostty. These are not NEW acceptance blockers, and if you'd like to fix them before or after NEW acceptance, assuming that you agree that at least some are to be fixed. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2139393 Title: [needs-packaging] ghostty To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/2139393/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
