Hi, thanks for another review iteration!

Here is my response to the comments:

> I: ghostty source: debian-rules-parses-dpkg-parsechangelog [debian/rules:10]
> I: ghostty source: debian-rules-parses-dpkg-parsechangelog [debian/rules:6]
> I: ghostty source: unnecessary-source-date-epoch-assignment [debian/rules:10]
This is needed, unfortunately. Zig resets the timestamps of resource files 
(Ghostty theme files) to Epoch *during install*. And LP does not accept binary 
uploads with such "file(s) with a time stamp too far in the past".

> I: ghostty source: older-debian-watch-file-standard 4 [debian/watch]
I bumped the version to 5. I think the syntax is still valid and need not be 
changed.

> I: ghostty source: license-file-listed-in-debian-copyright 
> zig-vendor/gettext-*/gettext-tools/tree-sitter-0.23.2/lib/src/unicode/LICENSE 
> [debian/copyright]
> I: ghostty source: license-file-listed-in-debian-copyright 
> zig-vendor/gtk4_layer_shell-N-V-__8AALiNBAA-_0gprYr92CjrMj1I5bqNu0TSJOnjFNSr/LICENSE
>  [debian/copyright]
> I: ghostty source: license-file-listed-in-debian-copyright 
> zig-vendor/highway-N-V-__8AAGmZhABbsPJLfbqrh6JTHsXhY6qCaLAQyx25e0XE/LICENSE 
> [debian/copyright]
> I: ghostty source: license-file-listed-in-debian-copyright ... use 
> "--tag-display-limit 0" to see all (or pipe to a file/program)
Removed.


> I: ghostty source: unused-license-paragraph-in-dep5-copyright apsl-2.0 
> [debian/copyright:5942]
> I: ghostty source: unused-license-paragraph-in-dep5-copyright artistic-1.0 
> [debian/copyright:6868]
> I: ghostty source: unused-license-paragraph-in-dep5-copyright bsd-4-clause 
> [debian/copyright:6364]
> I: ghostty source: unused-license-paragraph-in-dep5-copyright ... use 
> "--tag-display-limit 0" to see all (or pipe to a file/program)
All unused licenses removed.


> I: ghostty source: unused-override 
> source-contains-autogenerated-visual-c++-file * 
> [debian/source/lintian-overrides:3]
Override removed.


> P: redundant-priority-optional-field
Fixed.


> Moreover, I think all d/t/control tests but the `xvfb-run` one should be 
> marked with:
>   Restrictions: superficial
Done.


I updated the packaging source at: 
https://code.launchpad.net/~pushkarnk/+git/ghostty

LP is currently down and I am unable to upload the package to a PPA.
I'll update this bug as soon as that happens.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2139393

Title:
  [needs-packaging] ghostty

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+bug/2139393/+subscriptions


-- 
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to