I'm reviewing the stonking upload[1] for multiverse->universe
"promotion", NEW binary, and general packaging review.
I'll record some notes here that may be good to address in a future
upload:
a) dgx-desktop-nvidia-cuda-environment.postinst
+ touch /var/run/reboot-required || true
+ if ! grep -Fqsx dgx-desktop-nvidia-cuda-environment
/run/reboot-required.pkgs; then
+ echo dgx-desktop-nvidia-cuda-environment >>
/run/reboot-required.pkgs || true
+ fi
We have a helper for this, the pattern seems to be (taken from
gnome-shell.postinst):
# trigger an update notification that recommends a reboot
# (used by unattended-upgrades etc.)
touch /var/run/reboot-required || true
# same thing for the older update-notifier interface
if [ -x /usr/share/update-notifier/notify-reboot-required ]; then
/usr/share/update-notifier/notify-reboot-required || true
fi
b) set-cuda-gb300.sh timeout
Used in the one-shot cuda-gpu-select.service unit, I see a max-60s loop,
without any status report. Could this delay boot significantly?
In fact, the systemd timeout is lower than 60s, so it will complain
first:
$ time sudo systemctl start cuda-gpu-select.service
Job for cuda-gpu-select.service failed because the control process exited with
error code.
See "systemctl status cuda-gpu-select.service" and "journalctl -xeu
cuda-gpu-select.service" for details.
real 0m40.826s
c) set-cuda-gb300.sh creates /etc/cuda-gpu-select/env on-the-fly. This file
isn't "protected" by the normal configuration-file mechanisms from dpkg, maybe
a warning at the top would be a good idea ("don't change this file, it's
created automatically, blabla"). But what I wanted to highlight is that it
should probably be removed when purging dgx-desktop-nvidia-cuda-environment.
d) linux-nvidia recommends
bin:dgx-desktop-kernel-configuration recommends linux-nvidia, but I didn't find
it in stonking. Was it just not uploaded yet?
None of these are blockers for the NEW review, or accepting into universe.
1. https://launchpad.net/ubuntu/+source/dgx-desktop-defaults/1.1ubuntu
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2154816
Title:
[MIR] dgx-desktop-defaults
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/dgx-desktop-defaults/+bug/2154816/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
