I've rejected this from the queue; there's nothing hugely wrong, but
enough that I think it's worth doing another round. The first two
complaints should be fixed; the other ones marked “non-blocking” are
optional.
Please give me a ping in #devel:ubuntu.com once you've uploaded a new
package and I'll promptly re-review it.
```
override_dh_installsystemd:
# Do not start nvidia-mig-manager.service when installing this package
# because NVIDIA does the same on their own packaging.
dh_installsystemd --no-start
```
This is strange — this will automatically start the nvidia-mig-manager service
next boot, but not immediately on install. This is not what policy would
usually suggest (either immediately start or not start until explicitly
enabled).
Reading through, my *guess* is that this is because starting the service
will sometimes reboot the system(!), which is a reasonable thing to want
to avoid; documenting the reasoning here would be helpful.
```
# Copy some files from upstream packaging
cp -r deployments/systemd/packages/debian/postinst
debian/nvidia-mig-manager.postinst
cp -r deployments/systemd/packages/debian/postrm
debian/nvidia-mig-manager.postrm
```
I don't *think* this is explicitly against policy, but Ubuntu packaging
metadata (ie: the content of debian/) should be maintained by Ubuntu. You're
welcome to base your post{inst,rm} files on the upstream ones, but those
maintainer scripts should be in debian/ in the source package.
Non-blocking copyright notes:
=============================
* missing Copyright holder for
vendor/github.com/sirupsen/logrus/alt_exit.go Copyright (c) 2012 Miki
Tebeka <[email protected]> (the license is the same as the
surrounding code, so this is non-blocking)
* Technically, vendor/github.com/urfave/cli/v2/sliceflag.go should be
“Expat and BSD-3-Clause”; licensecheck is wrong here, the license it
finds is only for a fraction of the file.
* Duplicate stanzas: the stanza for the Expat exceptions in yaml/v3 &
yaml/v2 are duplicated
* vendor/github.com/NVIDIA/go-nvlib/pkg/pciids/default_pci.ids is
“BSD-3 or GPL-2+” (we're distributing it under BSD-3, so this is a nit)
Non-blocking behaviour/upstream nits:
============================
* /etc/nvidia-mig-manager/service.sh is not configuration and should really be
in /usr/libexec/nvidia-mig-manager
* utils.sh is also not configuration; this would more properly go in
/usr/share/nvidia-mig-manager
* The autogenerated config.yaml would more properly be in
/run/nvidia-mig-manager.
* Generally, the scripts could avoid the `CURDIR` lookup dance; we know where
they're going to be installed, and can just hardcode the correct directories.
(It seems from the documentation that hooks.sh *is* partially intended
to be configuration, so should remain in /etc.)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2139070
Title:
[needs-packaging] mig-parted
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+bug/2139070/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
