I'm reviewing this following the [documentation](https://ubuntu.com/project/docs/contributors/advanced/review- a-merge-proposal/#review-checklist-template)
* Changelog: - [+] Changelog entry has correct version and targeted codename - [+] Correct formatting of changelog items - [+] Bug references correct - [N] Old content and logical tag match as expected (Package Merge) * Release notes and Documentation - [+] Added, updated, or enqueued relevant documentation. - [+] Added, updated, or enqueued relevant release notes. * New patches: - [N] No new patches added - [+] Patches match those proposed/committed upstream - [+] Patches correctly included in debian/patches/series - [+] Patches have correct DEP-3 metadata - [+] Patches follow our style choices - [+] New code not from upstream was forwarded or marked as Ubuntu-only * Git/maintenance: - [+] Commits are properly split (more important on -dev than on SRUs) * Build/Test: - [+] Build is OK - [+] This is an SRU, the validation instructions are ok - [+] Testcases added or adapted (N/A if not strictly required or already present) - [+] autopkgtest against the PPA package passes (if possible, evidence was provided already) - [+] Based on PPA builds and the build-log, no new component mismatch expected - [N] Verified PPA package installs/uninstalls - [N] Verified PPA source package matches Merge Proposal source package - [+] Verified function manually You haven't uploaded this one to a PPA, or I could not find it. But nevermind, the code looks good. I've ran the autopgtests. As expected from https://bugs.launchpad.net/ubuntu/+source/ubuntu-cuda-packaging-tools/+bug/2164908, they fail with the current state of the Resolute archive but succeed with the submitted ubuntu-cuda-packaging-tools version. So, ``` $ ucms upload -c 13.1.2 cuda-crt --archive INFO [MainProcess] Using CUDA version: 13.1.2 main.py:45 About to upload 1 source package(s) DIRECTLY to the Ubuntu archive ┏━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓ ┃ Source Package ┃ Version ┃ Series ┃ .changes file ┃ ┡━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┩ │ cuda-crt-13-1 │ 13.1.115-0ubuntu1.1 │ resolute │ cuda-crt-13-1_13.1.115-0ubuntu1.1_source.changes │ └────────────────┴─────────────────────┴──────────┴──────────────────────────────────────────────────┘ WARNING [MainProcess] This action will upload directly to the Ubuntu archive and cannot be undone. processor.py:1326 Are you sure? [y/N]: y Uploading cuda-crt-13-1 using ftp to ubuntu (host: upload.ubuntu.com; directory: /ubuntu) running supported-distribution: check whether the target distribution is currently supported (using distro-info) {'allowed': ['release', 'proposed', 'backports', 'security'], 'known': ['release', 'proposed', 'updates', 'backports', 'security']} running required-fields: check whether a field is present and non-empty in the changes file running checksum: verify checksums before uploading running suite-mismatch: check the target distribution for common errors running check-debs: makes sure the upload contains a binary package running gpg: check GnuPG signatures before the upload Uploading cuda-crt-13-1_13.1.115-0ubuntu1.1.dsc Uploading cuda-crt-13-1_13.1.115-0ubuntu1.1.debian.tar.xz Uploading cuda-crt-13-1_13.1.115-0ubuntu1.1_source.buildinfo Uploading cuda-crt-13-1_13.1.115-0ubuntu1.1_source.changes ``` -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2155233 Title: cuda-toolkit cannot compile minimal example To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/cuda-crt-13-1/+bug/2155233/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
