Tested using rdmacg-test (attached).
Baseline (linux-image-7.0.0-2018-nvidia-bos-64k)
$ make
make -C /lib/modules/7.0.0-2018-nvidia-bos-64k/build M=/root/rdmacg-test modules
make[1]: Entering directory '/usr/src/linux-headers-7.0.0-2018-nvidia-bos-64k'
make[2]: Entering directory '/root/rdmacg-test'
warning: the compiler differs from the one used to build the kernel
The kernel was built by: aarch64-linux-gnu-gcc (Ubuntu 15.2.0-16ubuntu1)
15.2.0
You are using: gcc (Ubuntu 15.2.0-16ubuntu1) 15.2.0
warning: pahole version differs from the one used to build the kernel
The kernel was built with: 131
You are using: 0
CC [M] rdmacg_test.o
rdmacg_test.c: In function ‘rdmacg_test_find_locked’:
rdmacg_test.c:73:35: error: ‘struct rdmacg_device’ has no member named ‘index’
73 | if (dev->cg_device.index == index && !strcmp(dev->name,
name))
| ^
rdmacg_test.c: In function ‘rdmacg_test_add’:
rdmacg_test.c:115:23: error: ‘struct rdmacg_device’ has no member named ‘index’
115 | dev->cg_device.index = index;
| ^
rdmacg_test.c: In function ‘rdmacg_test_status_show’:
rdmacg_test.c:361:42: error: ‘struct rdmacg_device’ has no member named ‘index’
361 | dev->cg_device.index, dev->nr_charges);
| ^
make[4]: ***
[/usr/src/linux-headers-7.0.0-2018-nvidia-bos-64k/scripts/Makefile.build:289:
rdmacg_test.o] Error 1
make[3]: *** [/usr/src/linux-headers-7.0.0-2018-nvidia-bos-64k/Makefile:2134:
.] Error 2
make[2]: *** [/usr/src/linux-headers-7.0.0-2018-nvidia-bos-64k/Makefile:248:
__sub-make] Error 2
make[2]: Leaving directory '/root/rdmacg-test'
make[1]: *** [Makefile:248: __sub-make] Error 2
make[1]: Leaving directory '/usr/src/linux-headers-7.0.0-2018-nvidia-bos-64k'
make: *** [Makefile:7: all] Error 2
Candidate (linux-image-7.0.0-2019-nvidia-bos-64k)
$ ./rdmacg_test.sh
# using cgroup v2 hierarchy at /sys/fs/cgroup
1..29
ok 1 - unique name: listed once
ok 2 - unique name: no index= in rdma.max
ok 3 - unique name: no index= in rdma.current
ok 4 - unique name: default limit is max
ok 5 - unique name: name-only write accepted
ok 6 - unique name: limit applied
ok 7 - unique name: index= is optional but accepted
ok 8 - unique name: indexed write applied
ok 9 - unique name: wrong index rejected
ok 10 - unknown device rejected
ok 11 - duplicate names: both listed
ok 12 - duplicate names: index= present in rdma.max
ok 13 - duplicate names: index= present in rdma.current
ok 14 - duplicate names: unique device keeps bare name
ok 15 - duplicate names: name-only write rejected
ok 16 - duplicate names: indexed write accepted
ok 17 - duplicate names: limit hit the selected device
ok 18 - duplicate names: other device untouched
ok 19 - charge within limit on index=90002
ok 20 - usage visible in rdma.current
ok 21 - charge over limit on index=90002 fails
ok 22 - same name, index=90003 is unlimited
ok 23 - name unique again: index= dropped
ok 24 - name unique again: name-only write accepted
ok 25 - truncated 'max' rejected
ok 26 - empty resource value rejected
ok 27 - empty index value rejected
ok 28 - repeated index rejected
ok 29 - negative limit rejected
# passed 29/29
Test result good.
** Attachment added: "test module"
https://bugs.launchpad.net/ubuntu/+source/linux-nvidia/+bug/2167390/+attachment/6002391/+files/rdmacg-test.tar.xz
** Tags removed: verification-needed-resolute-linux-nvidia-bos
** Tags added: verification-done-resolute-linux-nvidia-bos
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/2167390
Title:
Backport "RDMA/cgroup: Disambiguate devices across net namespaces"
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-nvidia/+bug/2167390/+subscriptions
--
ubuntu-bugs mailing list
[email protected]
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
