Public bug reported: roundcube 1.6.18+dfsg-1 fails to build from source in stonking.
Regressing architectures (built before, fail now): amd64 (arch:all build). Build log(s): - https://launchpad.net/ubuntu/+source/roundcube/1.6.18+dfsg-1/+build/33493674/+files/buildlog_ubuntu-stonking-amd64.roundcube_1.6.18+dfsg-1_BUILDING.txt.gz Diagnosis (deterministic matcher): testsuite-failure — make[1]: *** [debian/rules:109: override_dh_auto_test] Error 2 Root cause: PHP 8.5 (php8.5 8.5.9-0ubuntu1 in stonking) provides a native, strictly typed array_first(array $array). roundcube's function_exists-guarded polyfill in program/lib/Roundcube/bootstrap.php is therefore not used, and the unit test Framework_Bootstrap::test_array_first (tests/Framework/Bootstrap.php:155), which asserts array_first(false) === null, dies with: TypeError: array_first(): Argument #1 ($array) must be of type array, false given (1 error of 1245 tests). Fix upstream (master, not backported to release-1.6; still present in 1.6.19): https://github.com/roundcube/roundcubemail/commit/060fc95672498993d37e57f74d146a087eb572e0 ("PHP 8.5 compat. fixes" — drops the non-array array_first() test assertions) Suggested: cherry-pick the test hunk as a debian/patches entry in an Ubuntu delta. Also review, for runtime callers that may pass non-arrays under PHP 8.5: https://github.com/roundcube/roundcubemail/commit/1e55383302f7c04769c82e3dd8383603f4824e1e Upstream discussion: https://github.com/roundcube/roundcubemail/issues/9961 Debian 1.6.19+dfsg-1 (unstable) does not fix this; no matching Debian bug. Related: LP: #2153394 (same PHP 8.5 array_first root cause, runtime redeclare fatal in 1.6.11). ** Affects: roundcube (Ubuntu) Importance: Undecided Status: New ** Tags: ftbfs stonking update-excuse ** Tags added: ftbfs stonking update-excuse -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2169077 Title: roundcube 1.6.18+dfsg-1 FTBFS: test_array_first TypeError with PHP 8.5 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/roundcube/+bug/2169077/+subscriptions -- ubuntu-bugs mailing list [email protected] https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
