I don't think this patch is correct.

-    grep -q disabled $BLUETOOTH
+    grep -i -n1 -q disabled $BLUETOOTH

As shown above, there is only *one* line that may match 'disabled', and
that's the 'status' line.  The following 'commands:' line lists only
'disable' without the 'd', so this patch is a no-op (except that it
makes the check a little more fragile in the case of other file format
changes).

case "$manufacturer" in
    LENOVO*)
        #if you are Lenovo Thinkpad
        #All Lenovo laptops now have an rf_kill swith
        #for wireless cards. So only manipulate bluetooh.

I assume this refers to the hardware kill switch?  Yes, I have a
hardware kill switch on my Lenovo laptop, but at least at one time,
toggling the switch was known to crash the kernel.  So I don't use the
hardware kill switch, I rely on Fn-F5 doing the right thing for my
wireless+bluetooth.  (Which it currently doesn't anyway, but that's
orthogonal.)

So I don't think this patch should be applied.

-- 
Add better behavior & fix for bluetooth with Lenovo Thinkpads (Code included)
https://bugs.launchpad.net/bugs/183682
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Reply via email to