Hi all,

It looks like the below patch breaks the build when the compiler
defines __thumb2__. I don't see how this patch was intended to work -
arm_asm.h does not define __USE_BX__ and it does not seem suitable to
include in C files. I would suggest the patch is reverted.

commit 3862c65a05983b2b18cb7884a124a905828f7a18
Author: Yann E. MORIN <[email protected]>
Date:   Sun Jan 9 01:45:08 2011 +0100

    ARM: #include <bits/arm_asm.h> where __USE_BX__ is used

    The check for __USE_BX__ will be available in bits/arm_asm.h,
    so the latter must be included wherever the former is used.

    Signed-off-by: "Yann E. MORIN" <[email protected]>
    Cc: Khem Raj <[email protected]>
    Cc: Bernhard Reutner-Fischer <[email protected]>
    Cc: Carmelo AMOROSO <[email protected]>
    Signed-off-by: Khem Raj <[email protected]>

Build log:

  CC ldso/ldso/ldso.oS
In file included from ./ldso/include/dl-defs.h:77:0,
                 from ./ldso/include/dl-string.h:16,
                 from ./ldso/include/ldso.h:48,
                 from ldso/ldso/ldso.c:33:
./ldso/ldso/arm/dl-sysdep.h: In function 'elf_machine_load_address':
./ldso/ldso/arm/dl-sysdep.h:119:37: warning: taking address of
expression of type 'void' [enabled by default]
In file included from ldso/ldso/ldso.c:46:0:
ldso/ldso/arm/elfinterp.c: In function '_dl_linux_resolver':
ldso/ldso/arm/elfinterp.c:72:11: warning: assignment makes integer
from pointer without a cast [enabled by default]
ldso/ldso/arm/elfinterp.c: In function '_dl_do_reloc':
ldso/ldso/arm/elfinterp.c:206:15: warning: assignment makes integer
from pointer without a cast [enabled by default]
ldso/ldso/arm/elfinterp.c:193:22: warning: variable 'def_mod' set but
not used [-Wunused-but-set-variable]
In file included from ./ldso/ldso/arm/dl-startup.h:10:0,
                 from ldso/ldso/dl-startup.c:95,
                 from ldso/ldso/ldso.c:87:
./include/bits/arm_asm.h: At top level:
./include/bits/arm_asm.h:6:1: error: expected identifier or '(' before '.' token
make: *** [ldso/ldso/ldso.oS] Error 1
_______________________________________________
uClibc mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/uclibc

Reply via email to