>>>>> "Will" == Will Newton <[email protected]> writes:
Will> Hi all, Will> It looks like the below patch breaks the build when the compiler Will> defines __thumb2__. I don't see how this patch was intended to work - Will> arm_asm.h does not define __USE_BX__ and it does not seem suitable to Will> include in C files. I would suggest the patch is reverted. It's probably a good idea to CC Yann on this.. Will> commit 3862c65a05983b2b18cb7884a124a905828f7a18 Will> Author: Yann E. MORIN <[email protected]> Will> Date: Sun Jan 9 01:45:08 2011 +0100 Will> ARM: #include <bits/arm_asm.h> where __USE_BX__ is used Will> The check for __USE_BX__ will be available in bits/arm_asm.h, Will> so the latter must be included wherever the former is used. Will> Signed-off-by: "Yann E. MORIN" <[email protected]> Will> Cc: Khem Raj <[email protected]> Will> Cc: Bernhard Reutner-Fischer <[email protected]> Will> Cc: Carmelo AMOROSO <[email protected]> Will> Signed-off-by: Khem Raj <[email protected]> Will> Build log: Will> CC ldso/ldso/ldso.oS Will> In file included from ./ldso/include/dl-defs.h:77:0, Will> from ./ldso/include/dl-string.h:16, Will> from ./ldso/include/ldso.h:48, Will> from ldso/ldso/ldso.c:33: Will> ./ldso/ldso/arm/dl-sysdep.h: In function 'elf_machine_load_address': Will> ./ldso/ldso/arm/dl-sysdep.h:119:37: warning: taking address of Will> expression of type 'void' [enabled by default] Will> In file included from ldso/ldso/ldso.c:46:0: Will> ldso/ldso/arm/elfinterp.c: In function '_dl_linux_resolver': Will> ldso/ldso/arm/elfinterp.c:72:11: warning: assignment makes integer Will> from pointer without a cast [enabled by default] Will> ldso/ldso/arm/elfinterp.c: In function '_dl_do_reloc': Will> ldso/ldso/arm/elfinterp.c:206:15: warning: assignment makes integer Will> from pointer without a cast [enabled by default] Will> ldso/ldso/arm/elfinterp.c:193:22: warning: variable 'def_mod' set but Will> not used [-Wunused-but-set-variable] Will> In file included from ./ldso/ldso/arm/dl-startup.h:10:0, Will> from ldso/ldso/dl-startup.c:95, Will> from ldso/ldso/ldso.c:87: Will> ./include/bits/arm_asm.h: At top level: Will> ./include/bits/arm_asm.h:6:1: error: expected identifier or '(' before '.' token Will> make: *** [ldso/ldso/ldso.oS] Error 1 Will> _______________________________________________ Will> uClibc mailing list Will> [email protected] Will> http://lists.busybox.net/mailman/listinfo/uclibc -- Bye, Peter Korsgaard _______________________________________________ uClibc mailing list [email protected] http://lists.busybox.net/mailman/listinfo/uclibc
