Hi Matt, Matt Waddel wrote:
The attached patch adds support for the enhanced DMA (eDMA) driver found in many Coldfire platforms. This patch only provides support for the M5329 platform. The driver also contains a simple test program that can be used to validate the eDMA driver. If everything is working correctly you should see results like these when you insmod the test code:
Do you want me to push this into the -uc releases only, or consider for merging into mainline? To goto mainline it will need a few cleanups :-) Run scripts/checkpatch.pl on it, there is a few things it complains about. One thing that I think needs looking at is the use of:
#define MCF_EDMA_CR *(volatile unsigned long *)(0xFC044000)
I think it would be better to just make these definitions the address only. Then use the appropriate readl() and writel() macros with these when used in the code. Regards Greg
=============================================== Starting eDMA transfer tests! DMA channel 14 testing started. Data transfered correctly. DMA channel 14 testing complete. ------------------------------- DMA channel 15 testing started. Data transfered correctly. DMA channel 15 testing complete. ------------------------------- DMA channel 13 testing started. Data transfered correctly. DMA channel 13 testing complete. ------------------------------- DMA channel 1 testing started. Data transfered correctly. DMA channel 1 testing complete. ------------------------------- DMA channel 2 testing started. Data transfered correctly. DMA channel 2 testing complete. ------------------------------- DMA channel 5 testing started. Data transfered correctly. DMA channel 5 testing complete. ------------------------------- DMA channel 6 testing started. Data transfered correctly. DMA channel 6 testing complete. ------------------------------- DMA channel 7 testing started. Data transfered correctly. DMA channel 7 testing complete. ------------------------------- DMA channel 8 testing started. Data transfered correctly. DMA channel 8 testing complete. ------------------------------- All tests have completed Automatically allocated 9 eDMA channels: 1, 2, 5, 6, 7, 8, 13, 14, 15, =============================================== Best regards, Matt ------------------------------------------------------------------------ _______________________________________________ uClinux-dev mailing list [email protected] http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by [email protected] To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev
-- ------------------------------------------------------------------------ Greg Ungerer -- Principal Engineer EMAIL: [email protected] SnapGear, a McAfee Company PHONE: +61 7 3435 2888 825 Stanley St, FAX: +61 7 3891 3630 Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com _______________________________________________ uClinux-dev mailing list [email protected] http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by [email protected] To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev
