Hi Matt,
Matt Waddel wrote:
Greg Ungerer wrote:
Matt Waddel wrote:
The attached patch adds support for the enhanced DMA (eDMA) driver
found in many Coldfire platforms. This patch only provides support
for the M5329 platform. The driver also contains a simple test
program that can be used to validate the eDMA driver. If everything
is working correctly you should see results like these when you
insmod the test code:
Do you want me to push this into the -uc releases only,
or consider for merging into mainline?
I'd be really happy if this went to mainline, so I'll work
on the checkpatch complaints and submit a new patch (or
would you prefer a patch against the patch?).
A new complete patch is best. To push to mainline it is
easiest if I have the complete patch, then I can just git
commit it to the public m68knommu git tree on kernel.org.
Thanks
Greg
To goto mainline it will need a few cleanups :-)
Run scripts/checkpatch.pl on it, there is a few things
it complains about.
One thing that I think needs looking at is the use of:
#define MCF_EDMA_CR *(volatile unsigned long *)(0xFC044000)
I think it would be better to just make these definitions the
address only. Then use the appropriate readl() and writel()
macros with these when used in the code.
Regards
Greg
uClinux-dev mailing list
[email protected]
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by [email protected]
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev
_______________________________________________
uClinux-dev mailing list
[email protected]
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by [email protected]
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev
--
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: [email protected]
SnapGear, a McAfee Company PHONE: +61 7 3435 2888
825 Stanley St, FAX: +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com
_______________________________________________
uClinux-dev mailing list
[email protected]
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by [email protected]
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev
