Hi Greg, On Thu, Nov 11, 2010 at 11:48:42AM +1000, Greg Ungerer wrote: ... > +#ifdef CONFIG_COLDFIRE_SW_A7 > +#define CACHE_INIT (CACR_CINV + CACR_DISD) > +#define CACHE_MODE (CACR_CENB + CACR_DISD + CACR_DCM) > +#else > +#define CACHE_INIT (CACR_CINV + CACR_DISD + CACR_EUSP) > +#define CACHE_MODE (CACR_CENB + CACR_DISD + CACR_DCM + CACR_EUSP) > +#endif
Wouldn't that be more maintainable as : #ifdef CONFIG_COLDFIRE_SW_A7 #define USERA7_MODE 0 #else #define USERA7_MODE CACR_EUSP #endif #define CACHE_INIT (CACR_CINV + CACR_DISD + USERA7_MODE) #define CACHE_MODE (CACR_CENB + CACR_DISD + CACR_DCM + USERA7_MODE) Philippe _______________________________________________ uClinux-dev mailing list uClinux-dev@uclinux.org http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by uclinux-dev@uclinux.org To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev
