Hi Philippe,
On 11/11/10 19:01, Philippe De Muyter wrote:
Hi Greg,
On Thu, Nov 11, 2010 at 11:48:42AM +1000, Greg Ungerer wrote:
...
+#ifdef CONFIG_COLDFIRE_SW_A7
+#define CACHE_INIT (CACR_CINV + CACR_DISD)
+#define CACHE_MODE (CACR_CENB + CACR_DISD + CACR_DCM)
+#else
+#define CACHE_INIT (CACR_CINV + CACR_DISD + CACR_EUSP)
+#define CACHE_MODE (CACR_CENB + CACR_DISD + CACR_DCM + CACR_EUSP)
+#endif
Wouldn't that be more maintainable as :
#ifdef CONFIG_COLDFIRE_SW_A7
#define USERA7_MODE 0
#else
#define USERA7_MODE CACR_EUSP
#endif
#define CACHE_INIT (CACR_CINV + CACR_DISD + USERA7_MODE)
#define CACHE_MODE (CACR_CENB + CACR_DISD + CACR_DCM + USERA7_MODE)
Possibly, yes. Interestingly the above changes again in patch 8,
where the parts that support a split cache is the same parts that
support the eusp. Based on the above idea I think I can clean that
up a little to only have a single definition of CACHE_INIT and
CACHE_MODE. Let me rework that and resend that patch.
Thanks
Greg
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: g...@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
_______________________________________________
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev
