Hi Peter, On 06/08/11 00:43, Peter Turczak wrote:
while porting linux kernel 3.0 to a 5208 hardware I found the mcf-i2c driver went missing over the years. I ported the driver Derek CL Cheung's driver forward.
As far as I know this has never been in mainline kernels. I have been carrying a version of it around in the uClinux-dist linux-2.6.x sources for a while - as drivers/char/i2c-mcf.[hc] That looks to be similar, though not completely identical, to the driver you have attached here.
This is tested on an mcf5208 board with several LM75s. Greg: Would you please check if it could be merged upstream?
At the very least there is some style issues that need to be fixed first. Only /* */ style comments should be used for one thing. Easiest way to find style issues is to run: scripts/checkpatch.pl from within the kernel source tree. This patch would also need to be sent to the i2c mailing list (http://vger.kernel.org/vger-lists.html#linux-i2c) so it can go to mainline via the i2c git tree. I can certainly take ColdFire specific header file changes, after being cleaned up. Regards Greg ------------------------------------------------------------------------ Greg Ungerer -- Principal Engineer EMAIL: g...@snapgear.com SnapGear Group, McAfee PHONE: +61 7 3435 2888 8 Gardner Close FAX: +61 7 3217 5323 Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com _______________________________________________ uClinux-dev mailing list uClinux-dev@uclinux.org http://mailman.uclinux.org/mailman/listinfo/uclinux-dev This message was resent by uclinux-dev@uclinux.org To unsubscribe see: http://mailman.uclinux.org/mailman/options/uclinux-dev
