Hi Steven,

On 23/05/12 12:03, Steven King wrote:
The 5441x (54410/54415/54416/54417/54418) is similar to the 532x in the same
way the 532x is similar to the 5208; it doesn't have either IPSBAR nor MBAR,
instead everything resides at a fixed address.  Many of the registers common
between the 5441x and the 532x live at the same address as the 532x, but of
course the 5441x has a v4e core, cache and mmu, along with 10 uarts! 6 i2c

What a wacky Soc. I wonder what people are using them in :-)


controllers, 4 dma capable spi controllers, usb and much more.  This patch is
just a quick and dirty hack to get it booting on the twr-mcf5441x board.  Its
currently nommu only (well, I havent even tried it with the mmu),  It doesnt
include support for the 2 fec controllers, the ones on the 5441x are just
slightly different in some non obvious way so they dont quite work yet.

Signed-off-by: Steven King<sfk...@fdwdc.com>

This looks pretty good overall. Only a couple of comments below.
Otherwise I'd like to commit it to the m68knommu git tree (after the current
merge window closes).


---
  arch/m68k/Kconfig.cpu                   |    7 +
  arch/m68k/Kconfig.machine               |    1 -
  arch/m68k/Makefile                      |    1 +
  arch/m68k/include/asm/gpio.h            |   11 +-
  arch/m68k/include/asm/m5441xsim.h       |  252 +++++++++++++++++++++++++++++++
  arch/m68k/include/asm/m54xxacr.h        |    4 +
  arch/m68k/include/asm/mcfsim.h          |    2 +
  arch/m68k/include/asm/mcftimer.h        |    2 +-
  arch/m68k/platform/coldfire/Makefile    |    1 +
  arch/m68k/platform/coldfire/device.c    |   38 ++++-
  arch/m68k/platform/coldfire/intc-simr.c |   24 ++-
  arch/m68k/platform/coldfire/m5441x.c    |   51 +++++++
  arch/m68k/platform/coldfire/timers.c    |    2 +-
  13 files changed, 382 insertions(+), 14 deletions(-)

diff --git a/arch/m68k/Kconfig.cpu b/arch/m68k/Kconfig.cpu
index 8a9c767..3221433 100644
--- a/arch/m68k/Kconfig.cpu
+++ b/arch/m68k/Kconfig.cpu
@@ -252,6 +252,13 @@ config M548x
        help
          Freescale ColdFire 5480/5481/5482/5483/5484/5485 processor support.

+config M5441x
+       bool "MCF5441x"
+       select MMU_COLDFIRE if MMU

Maybe we should make this "depends on !MMU" until we really do
have the MMU support in place. There is pretty much no way it will
compile and work with the MMU enabled yet.


+       select HAVE_CACHE_CB
+       help
+         Freescale Coldfire 54410/54415/54416/54417/54418 processor support.
+
  endif # COLDFIRE


diff --git a/arch/m68k/Kconfig.machine b/arch/m68k/Kconfig.machine
index 7cdf6b0..7031173 100644
--- a/arch/m68k/Kconfig.machine
+++ b/arch/m68k/Kconfig.machine
@@ -428,7 +428,6 @@ config SAVANTrosie1
        help
          Support for the Savant Rosie1 board.

-

I like clean ups... But they should go in separate patches of their own.


  if !MMU || COLDFIRE

  comment "Machine Options"
diff --git a/arch/m68k/Makefile b/arch/m68k/Makefile
index 804f139..6940baf 100644
--- a/arch/m68k/Makefile
+++ b/arch/m68k/Makefile
@@ -34,6 +34,7 @@ cpuflags-$(CONFIG_M68030)     :=
  cpuflags-$(CONFIG_M68020)     :=
  cpuflags-$(CONFIG_M68360)     := -m68332
  cpuflags-$(CONFIG_M68000)     := -m68000
+cpuflags-$(CONFIG_M5441x)      := $(call cc-option,-mcpu=54455,-mcfv4e)

What if the compiler supports neither -54455 or -mcfv4e?
Admittedly it would have to be a old compiler. But the thinking here
was that the second arg is the last resort fallback if the compiler
doesn't support the ideal compiler switch.

Regards
Greg


------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     g...@snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close                             FAX:         +61 7 3217 5323
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com
_______________________________________________
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev

Reply via email to