Hi Steven,
On 31/05/12 20:23, Steven King wrote:
On Thursday 24 May 2012 11:05:31 pm Greg Ungerer wrote:
+#ifdef CONFIG_M5441x
+#define FEC_NAME "enet-fec"
So I see that the iMX guys have used a device type prefix here for
the fec name. Does it make any sense to use something like that
for the 5441x as well? So "5441x-fec"? Or will we just not
need to distinguish it this way?
My thinking was that if tomorrow Freescale released a 'm5442x' with 4
enet-fecs then the same quirk would apply, but if it instead had a gigabit
enet-fec we'd still need a new quirk anyway; what I want to avoid was given
Freescale's fondness of producing varients, either using the wrong name for a
chip - 'my m5442x says it has 5441x-fec?' or having a half dozen quirk
entries that all selected the same feature. But I dont have strong feelings
about this, I just want the ethernet on my twr-mcf54418 to work.
That is certainly true, Freescale don't have a good track record when
it comes to consistency of naming and use.
I don't feel that strongly about it, feel free to use whatever you
think is best.
Regards
Greg
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: g...@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
_______________________________________________
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev
