Thanks Levi looks good +1
-- Jody Garnett On Monday, 16 July 2012 at 12:33 PM, Jody Garnett wrote: > Thanks Levi; I will read it over right away (we also have a Skype meeting > this evening and can cover it then). > > Feedback: > - EditFeatureListenerCache - there is an eclipse provided listener list > implementation that you can use here > - For each listener interface, please make an abstract abstract adaptor (i.e. > implement all the methods to do no harm so people can override quickly). So > it sounds like EditFeatureListenerImpl should be renamed to EditFeatureAdaptor > - you can handle dirty, visible, enabled, editable as Map<String,Boolean > > with associated accessor methods: isVisible( attribute ) etc… > - EditFeatureListener is now more capable then a PropertyChangeListener would > be so that idea can die. > - can we split the diagram into two: > a) FeatureInterceptor for feature create / active / inactive / delete > b) EditFeatureListener for all the events around "live" editing with a user > interface > - you may (or may not) wish to add FeatureInterceptor notification for the > "apply" and "cancel" transitions (i.e. persistence changes are often > considered "lifecycle") > > So with this in mind the earliest you can start committing is thursday (our > usual three day rule). > > -- > Jody Garnett > > > On Monday, 16 July 2012 at 11:53 AM, Levi Putna wrote: > > > Hey community, > > > > I sorry we didn't get to have out IRC catchup last week hoverer I was able > > to update the Feature editing workflow > > (http://udig.refractions.net/confluence/display/UDIG/Feature+editing+workflow) > > RFC with the help of jody and feel it is ready to for community > > review/submission. > > > > http://udig.refractions.net/confluence/display/UDIG/Feature+editing+workflow > > > > > > -- > > Levi Putna > > www.ozblog.com.au (http://www.ozblog.com.au) > > > > _______________________________________________ > > User-friendly Desktop Internet GIS (uDig) > > http://udig.refractions.net > > http://lists.refractions.net/mailman/listinfo/udig-devel > > > > > > > >
_______________________________________________ User-friendly Desktop Internet GIS (uDig) http://udig.refractions.net http://lists.refractions.net/mailman/listinfo/udig-devel