Hi Andrea: I should of tried for a longer status update; I was going to talk about my experience reviewing on a shared branch like that.
In general it was great to be able to work with naz and give him feedback right in the code (sometimes feedback was a new test dataset). However this branch was *so old* that I found I could not continue to rebase against master - the last straw was it offering me walk me through resolving conflicts as step 1 of 63! With that in mind I accepted this pull request as "Stage 1", and outlined two more steps on the RFC page. - Stage 1 Initial Shapefile implementation - Stage 2 General purpose implementation - Stage 3 Shapefile Attachment support I felt this was the best way to recover the work that Paul started back in January. The user docs are now in the udig/docs folder. udig/docs/user/en/Document view.rst udig/docs/user/en/Working with Documents.rst udig/docs/user/en/Adding a file hotline.rst udig/docs/user/en/Adding a web hotlink udig/docs/user/en/Configure hotlink attributes.rst These pages cannot be finalised until I finish the user interface to allow users to configure hotlink attributes; which was the work interrupted by trying to rebase. -- Jody Garnett On Tuesday, 24 July 2012 at 4:48 PM, andrea antonello wrote: > Hi Jody, > > > 1. I updated the user guide docs, and confirm the test cases pass for me > > etc, and accepted your pull request > > > > > I hoped to be able to test the thing before you accept the pull request. > Didn't I learn from you that first docs are online and then we check > and then the pull request can be accepted? :) > Anyways, where are the user docs, I can't see them on the RFC. > > Andrea > > PS: there was also another RFC that needed vote, can you please link > it again, so I can get over it? > > > 2. I have updated the RFC > > http://udig.refractions.net/confluence/display/UDIG/Document+View to > > indicate remaining tasks > > > > If you could review those remaining tasks it would be cool. > > -- > > Jody Garnett > > > > On Thursday, 19 July 2012 at 2:29 PM, Nazareno Chan wrote: > > > > Hi Guys, > > > > I’m working on the DocumentView RFC: > > http://udig.refractions.net/confluence/display/UDIG/Document+View > > > > And I would like to request a commit access to be able to push my changes > > up. > > > > Thanks! > > Naz Chan > > > > > > ________________________________ > > The contents of this email are confidential and may be subject to legal or > > professional privilege and copyright. No representation is made that this > > email is free of viruses or other defects. If you have received this > > communication in error, you may not copy or distribute any part of it or > > otherwise disclose its contents to anyone. Please advise the sender of your > > incorrect receipt of this correspondence. > > _______________________________________________ > > User-friendly Desktop Internet GIS (uDig) > > http://udig.refractions.net > > http://lists.refractions.net/mailman/listinfo/udig-devel > > > > > > > > _______________________________________________ > > User-friendly Desktop Internet GIS (uDig) > > http://udig.refractions.net > > http://lists.refractions.net/mailman/listinfo/udig-devel > > > > _______________________________________________ > User-friendly Desktop Internet GIS (uDig) > http://udig.refractions.net > http://lists.refractions.net/mailman/listinfo/udig-devel > >
_______________________________________________ User-friendly Desktop Internet GIS (uDig) http://udig.refractions.net http://lists.refractions.net/mailman/listinfo/udig-devel
