> I've designed a despeckling/denoising algorithm to solve issues with
> images taken under very difficult lighting conditions, deep sea diving
> in my case. It may be useful in other situations too. The reason to post
> it is that (after a number of incarnations which have been thrown away
> by me) I think this one is going to stay.

I'm not sure about the algorithm, but the code seems almost perfect,
so I applied the patch as is.

I'll have to dig up my underwater photos, so for now I only tried it
with a normal picture. The (50, 0, 5) parameters that you suggest give
me some artifact. I'm not sure that having window much larger than
passes makes sense, it make the algorithm very sensitive to the x,y
orientation of the photo. Or are you trying to get rid of sensor
banding? Some more background on the algorithm would be interesting.

There is a small bug in the "View channel" implementation, since it
modifies the live histogram. I think the correct place to implement
this is in preview_draw_area(). On the other hand, this function is
already a bit overloaded, and it has to be very fast, so I'm not sure.

Another thing is that I think the "View channel" should be reset when
switching out of the "despeckling page".

> Currently the interface has been added to the grayscale page but I think
> (if this is an acceptable feature at all) that it should be put in a
> separate denoise page. The next step is to add wavelet chroma denoising.
> The current wavelet denoising should be put in this page too IMHO.

Moving widgets between pages is easy, so I'm not worried about it too
much for now.

> There are no command-line options yet for this. It's easy but boring
> and doubtfully useful to add them because parameter settings are not
> expected to be generally applicable.

Good. I don't think that image parameters belong in the command-line,
they should be controlled with ID files. At some point I might try
remove some of the existing options.

Thanks for the patch,
Udi

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
ufraw-devel mailing list
ufraw-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ufraw-devel

Reply via email to